New issue
Advanced search Search tips

Issue 667234 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Canary: Drop event not fired

Reported by teo.eter...@gmail.com, Nov 21 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2923.0 Safari/537.36

Steps to reproduce the problem:
1.  See the video: https://www.youtube.com/watch?v=gA8mi4UQR7Y

What is the expected behavior?
The drop event should be called

What went wrong?
For some reason the drop event is not called when dropping outside the browser. The same issue is also when dropping inside the website.

Did this work before? Yes Chrome stable see video

Chrome version: 56.0.2923.0  Channel: n/a
OS Version: OS X 10.12.1
Flash Version: Shockwave Flash 24.0 r0

Didn't had time to inspect it properly(start of week lot of bugs) I can see what JS/DOM even't isn't called if it helps
 
Labels: M-56

Comment 2 by ajha@chromium.org, Nov 25 2016

Labels: Needs-Bisect

Comment 3 by ajha@chromium.org, Nov 25 2016

Cc: ajha@chromium.org
Components: -UI Blink>DOM>Events
Labels: Needs-Feedback
Thanks for filing this. 

Tried signing up to https://beta.ability.es/#/base/login as per video, to test this but I am not seeing any option to proceed with signing in there.

teo.eterovic@: If possible, could you please attach any test file with the above test case to try a repro from our end and check where this regressed.

Comment 4 by hayato@chromium.org, Nov 25 2016

Components: -Blink>DOM>Events Blink>Input
Removing Blink>DOM>Event since the issue sounds specific to Drop event.
Components: -Blink>Input Blink>DataTransfer
Cc: dcheng@chromium.org
Huh. I can't get any drop events to happen.

https://plnkr.co/edit/PO7Nt1TshKcBCduDiiOV?p=preview

do you mean dropend? or drop?

+dcheng, who knows about drag drop
Cc: dmu...@chromium.org
Cc: pwnall@chromium.org
Cc: -pwnall@chromium.org
Labels: -Needs-Bisect
Owner: pwnall@chromium.org
Status: WontFix (was: Unconfirmed)
According to the spec [1] drop is supposed to fire on the event that receives the drop. If the drop occurs outside the browser, there's no target, so there's no drop event. AFAIK, we do fire dragend on the source, and that's the right way to update the UI to reflect transitioning from drag-and-drop mode back into the normal interaction mode.

OP: If you can help me with additional information, such as code, I'd be happy to take another look at this issue. The video is not enough for me to figure out what's happening.

#6: You're not seeing a drop because the plnkr.co doesn't have the correct drag-and-drop setup. Unfortunately, this API is unnecessarily complicated. AFAIK, in order to get a drop, you need dragenter and dragover event listeners that call event.preventDefault(). Missing the event.preventDefault() call in any of these listeners is taken as a signal that the target element doesn't accept the drop, so there's no drop event.

[1] https://html.spec.whatwg.org/multipage/interaction.html#dndevents

Sign in to add a comment