Providing changelog as unable to Sign-in to chromium builds
https://chromium.googlesource.com/chromium/src/+log/56.0.2913.0..56.0.2914.0?pretty=fuller&n=10000

Suspecting: r430699 ?

Kindly help to re-assign, if your changes are not cause for this issue.

cc anthonyvd@ and ewald@

Same reason as  crbug.com/664410 . The sync confirm window doesn't show up for the second sign in. Good news is I found the real reason and will upload the fix soon. 

I don't understand. What's the "real reason," and how is this related to  Issue 664410 ? In  Issue 664410 , we are showing the sync confirmation screen when we shouldn't be (i.e. we shouldn't let a user who's already signed-in go through the confirmation dialogue). This issue is about the sync confirmation dialogue not appearing when trying to sign back in, in a very specific, odd scenario.

FWIW, I can't reproduce this issue on Mac.

Hi ewald@

In  crbug.com/664410  comments #7, I mentioned there are two issues. The first one is showing the sign in window(not the sync confirm) when we shouldn't be. The second one is the sync confirm window is closed automatically even before we displaying it. 
 
So this ticket has the same root cause as the second one in 664410. 

Thanks Owen. See https://bugs.chromium.org/p/chromium/issues/detail?id=664410#c14 for more details.

Note that this bug has nothing to do with opening another settings page in the background or having a sync passphrase. It simply is about the sync confirmation dialogue not appearing when signing in multiple times to the same profile.

Note that I'm also unable to repro it on Mac, so I'm taking off the "Mac" OS label.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff9fc46a4fdfb7c2975c867d8459e3cebe2e32fb

commit ff9fc46a4fdfb7c2975c867d8459e3cebe2e32fb
Author: zmin <zmin@chromium.org>
Date: Wed Nov 23 23:52:21 2016

UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog".

UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in of one profile when the force-sign-in is disabled. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled.

Theoretically, this function can be called multiple times in one sign-in process. However, the fact is, once it's called by the second time, the javascript message will be sent to the "sync confirm dialog" but not the "sign-in dialog" which will close the "sync confirm dialog" automatically and causes other issue.s

The quick fix here is making sure that the function will be called at most once no matter the force-sign-in is enabled or not.

BUG= 667227 

Review-Url: https://codereview.chromium.org/2519123003
Cr-Commit-Position: refs/heads/master@{#434287}

[modify] https://crrev.com/ff9fc46a4fdfb7c2975c867d8459e3cebe2e32fb/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

Verified in 57.0.2931.0 (64-bits) on Windows 10

This issue breaks the sign in process in M56 so the fix patch should be merged to M56.

Your change meets the bar and is auto-approved for M56 (branch: 2924)

Friendly ping for Owen to merge this CL :)

Hi ewald@

This CL above triggers another issue( crbug.com/668619 ) which was hidden by the issue here before. You can find more details there.

The second patch has been committed already but I'd like to verify both CLs on Canary and merge them together.

Got it, makes sense. Thanks Owen! :)

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Please merge your change to M56 (branch: 2924) ASAP so that we could take it for next Dev Release.

If there is no pending work after merging the CL please remove Merge-Approved-56 label and add merge-merged-2924.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc68fea1f07157b6ef761f348a3daae2e3ed7b2b

commit fc68fea1f07157b6ef761f348a3daae2e3ed7b2b
Author: Patrick Monette <pmonette@chromium.org>
Date: Wed Nov 30 23:43:12 2016

UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog".

UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in of one profile when the force-sign-in is disabled. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled.

Theoretically, this function can be called multiple times in one sign-in process. However, the fact is, once it's called by the second time, the javascript message will be sent to the "sync confirm dialog" but not the "sign-in dialog" which will close the "sync confirm dialog" automatically and causes other issue.s

The quick fix here is making sure that the function will be called at most once no matter the force-sign-in is enabled or not.

BUG= 667227 

Review-Url: https://codereview.chromium.org/2519123003
Cr-Commit-Position: refs/heads/master@{#434287}
(cherry picked from commit ff9fc46a4fdfb7c2975c867d8459e3cebe2e32fb)

Review URL: https://codereview.chromium.org/2542773002 .

Cr-Commit-Position: refs/branch-heads/2924@{#228}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/fc68fea1f07157b6ef761f348a3daae2e3ed7b2b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

Above issue is fix on Windows and Linux OS using Latest Chrome Version:56.0.2924.14 (Official Build) 0dc503a1d29c5c8d206cec080ef65b1950451575-refs/branch-heads/2924@{#277} 

Please find the attached screencast

Deleted: Actual_.14.mp4 1.7 MB

	Actual_.14.mp4 1.7 MB View Download

As per Comment# 16 adding TE-Verified Labels.
Thank You.