New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 667224 link

Starred by 6 users

Issue metadata

Status: Assigned
Owner:
Buried. Ping if important.
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Print preview on any page remains in forever loading state.

Reported by lpa...@etouch.net, Nov 21 2016

Issue description

Chrome Version: 57.0.2926.0 (Official Build da59d418f54604ba2451cd0ef3a9cd42c05ca530-refs/heads/master@{#433437} 32/64 Bit.
OS: Windows(7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6, 10.12.1) 

Steps:
1. Launch chrome, enable 'Experimental Web Platform features' flag from chrome://flags. 
2. Open a new tab page or any page and give print command i.e. Ctrl+P, observe.

Actual: Print preview is in forever loading state.

Expected: Print preview should load instantly.

This is a regression issue broken in M-56, will soon update other info.

Manual Regression Range:
Good Build: 56.0.2902.0
Bad Build: 56.0.2903.0
 
Actual.mp4
639 KB View Download
Expected.mp4
696 KB View Download
Cc: thestig@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: mkwst@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 56.0.2902.0 (Revision: 427892).
Bad build: 56.0.2903.0 (Revision: 428231).

You are probably looking for a change made after 428039 (known good), but no later than 428040 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/2ce641d6fa80fc0a9ea2fe1484f6040224e2a6a3..e285ee2fbabbe223bb36fe96f83bdb70d93ef643

@mkwst -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Adding RB Label as this is a recent Regression. Please remove if not required.

Thank You.
Is the experimental flag off by default? If so, this probably should not be P1 / RBS?

Comment 3 by mkwst@chromium.org, Nov 24 2016

Cc: a...@google.com tsepez@chromium.org
Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
We have an experiment running that disables automatic whitelisting of parser-inserted 'chrome-extension://' URLs. Looks like we use the PDF extension inside an HTML Import when rendering the print preview page. +aaj@.

I agree that this is neither P1 nor a release block, but I need to get it fixed so that we get reasonable data to make a decision about the behavior change.

I've uploaded a fix at https://codereview.chromium.org/2528903002, let's see what tsepez@ thinks. :)


Project Member

Comment 4 by bugdroid1@chromium.org, Nov 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5dd67fc5244bc8ee3fa74bea9835a0d054d2a37

commit c5dd67fc5244bc8ee3fa74bea9835a0d054d2a37
Author: mkwst <mkwst@chromium.org>
Date: Mon Nov 28 23:25:33 2016

Allow the PDF extension for chrome://print pages.

We have an experiment running that would disable parser-inserted usage
of 'chrome-extension://' URLs unless explicitly whitelisted. This breaks
the print preview page, which relies on the PDF extension URLs inside an
HTML import. So. This patch adds a mechanism for whitelisting that
extension URL for the print preview page.

BUG=667224
R=tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2528903002
Cr-Commit-Position: refs/heads/master@{#434770}

[modify] https://crrev.com/c5dd67fc5244bc8ee3fa74bea9835a0d054d2a37/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
[modify] https://crrev.com/c5dd67fc5244bc8ee3fa74bea9835a0d054d2a37/content/browser/webui/web_ui_data_source_impl.cc
[modify] https://crrev.com/c5dd67fc5244bc8ee3fa74bea9835a0d054d2a37/content/browser/webui/web_ui_data_source_impl.h
[modify] https://crrev.com/c5dd67fc5244bc8ee3fa74bea9835a0d054d2a37/content/public/browser/web_ui_data_source.h

Comment 5 by mkwst@chromium.org, Nov 29 2016

Cc: mkwst@chromium.org tkonch...@chromium.org nainar@chromium.org
 Issue 668918  has been merged into this issue.

Comment 6 by mkwst@chromium.org, Nov 29 2016

Assuming the CL fixes the issue in tomorrow's Canary, I'll request a merge back to M56.
Labels: TE-Verified-57.0.2979.0 TE-Verified-M57
Tested this issue on Mac 10.12.2, Win-10 and Ubuntu 14.04 using Chrome version #57.0.2979.0 as per the comment #0.

Observed that print preview loaded instantly as expected.

Hence, the fix is working as expected.

Attaching the screencast for reference

Adding the verified labels.

mkwst@ - Could you please merge it to M56.

Thanks...!!
667224.mp4
1.5 MB View Download
re #6: mkwst@ was this merged back to M56? I see the same issue in my M56 stable build on Linux with --enable-experimental-web-platform-features.

Looking at dev tools it is definitely "Content Security Policy directive" preventing the pdf viewer. 
Cc: majidvp@chromium.org

Sign in to add a comment