Regression: Switch person window closes when selecting avatar icon by pressing Enter key.
Reported by
lpa...@etouch.net,
Nov 21 2016
|
|||||||||||||
Issue descriptionVersion: 55.0.2883.59 (Official Build) beta 955e772956a140399de5d3cf35d6819d894ecd63-refs/branch-heads/2883@{#624} (32/64-bit) OS: Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (Ubuntu 14.04 LTS) What steps will reproduce the problem? 1) Launch chrome, click on avatar icon and select Manage people option (Switch person window opens). 2) Click on Add person and press Tab key (focus is on avatar icon). 3) Press right arrow key and then press Enter key and observe. On pressing Enter key Switch person window closes. On pressing Enter key Switch person window should not close. This is a Regression issue broken in M-55, will soon update other info Manual bisect: Good build: 55.0.2868.0 Bad build: 55.0.2869.0.
,
Nov 22 2016
Bisect Info: =========== Good build : 55.0.2868.0, Revision Range 420217 Bad build : 55.0.2869.0, Revision Range 420536 After executing the per-revision-bisect script, i got the following CL's between good and bad build versions =========================================== https://chromium.googlesource.com/chromium/src/+log/f5a394b0e277189a4e7d57b68bb1ae3a0f4ee3ee..41da613e2425d5cd726390dcecdb4102315900c1 The suspecting Change Log is : ----------- https://chromium.googlesource.com/chromium/src/+/41da613e2425d5cd726390dcecdb4102315900c1 From the above CL suspecting the below change --------------------------- https://codereview.chromium.org/2269743002 mahmadi@- Could you please look into this issue, if it's related to your change? if not could you please help us to reassign this issue to the right owner.
,
Nov 24 2016
,
Nov 24 2016
Just to update latest behavior, Issue is still observed on chrome latest M55 #55.0.2883.65. Observed window closes while pressing enter on switch person. mahmadi@ Since this issue is marked as P1 for M-55, Can we get any update on this issue?
,
Nov 30 2016
@mahmadi: Gentle Ping, can you please provide an update as mentioned in the above comment. Thanks.!
,
Dec 1 2016
msarda@ will be working on the User Manager. Assigning to him with priority 2.
,
Jan 2 2017
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 2 2017
,
Jan 11 2017
,
Jan 24 2017
Able to reproduce the issue on latest canary #58.0.2990.0 jlebel@ Could you please look into this issue & update the status Thanks.
,
Feb 23 2017
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 6 2017
,
Oct 26 2017
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfa633916c1086583e98c8b8611c154c639f3ff1 commit cfa633916c1086583e98c8b8611c154c639f3ff1 Author: Scott Chen <scottchen@chromium.org> Date: Mon Oct 30 14:03:24 2017 MD User Manager: fix excessively triggering user pod selections. Currently, in the (md_)user_pod_row.js code, there's key-down listeners that are bound directly on the document element, so its catching arrow/enter key events from the create-user or supervised-user interface, and triggering user-pod selections even while #user-pods-page is visually hidden. This CL stops any keydown event propagation from the interfaces mentioned above, as a solution with minimal code-change. A follow-up is recommended to examine whether or not it's necessary to bind listeners for user-pod selections on the entire document. Bug: 716999, 667216 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I329d7bc727d19e429199213ad16613024af2afa5 Reviewed-on: https://chromium-review.googlesource.com/739390 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#512486} [modify] https://crrev.com/cfa633916c1086583e98c8b8611c154c639f3ff1/chrome/browser/resources/md_user_manager/user_manager_pages.html [modify] https://crrev.com/cfa633916c1086583e98c8b8611c154c639f3ff1/chrome/browser/resources/md_user_manager/user_manager_pages.js
,
Oct 31 2017
Retested above issue on Windows(7,8,10), Mac(10.12.6) & Linux(14.04 LTS) OS using latest Canary #64.0.3254.0 and issue is fixed. Kindly review an attached screen cast.
,
Nov 1 2017
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by msrchandra@chromium.org
, Nov 21 2016Status: Untriaged (was: Unconfirmed)