Issue metadata
Sign in to add a comment
|
Regression : In devtools, hover effect is not seen on vertical scroll bar in ‘Timeline data’ section.
Reported by
yfulgaon...@etouch.net,
Nov 21 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version : 57.0.2926.0 (Official Build) da59d418f54604ba2451cd0ef3a9cd42c05ca530-refs/heads/master@{#433437} 64-bit OS : Mac(10.11.6, 10.12.1, 10.12) What steps will reproduce the problem? 1. Launch chrome, open NTP and open devtools. 2. Navigate to ‘Timeline’ tab and hit ‘Cmd + R’ to record the reload. 3. Now mouse hover on scroll bar in ‘Timeline data’ section and observe the scroll bar (Please review an attached screen cast) Actual : Hover effect is not seen on vertical scroll bar in ‘Timeline’ section. (Hover effect is only seen when hovering at the edge of the scroll bar) Expected : Hover effect should be seen on vertical scroll bar in ‘Timeline’ section. This is a regression issue broken in ‘M-56’, below is the Manual Regression range and will soon update other info. Good Build : 56.0.2910.0 Bad Build : 56.0.2912.0 Note : 1. This is Mac specific issue and the same is working fine on Windows & Linux OS.
,
Nov 21 2016
,
Nov 21 2016
This issue is related to my patch 524f6ac4628d3d5249d291314c6100bd0a337053. I will work on it.
,
Nov 21 2016
Interesting, this sounds like issue 656890 but I couldn't reproduce myself (and don't have access to a Mac today). Chao, can you check if that's the same issue?
,
Nov 22 2016
Document::updateHoverActiveState should only cancel hover and active state when hitting overlay scrollbar.
,
Nov 22 2016
Ah, to add to the repro instructions, you need to disable overlay scrollbars on Mac to reproduce this.
,
Nov 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb7a6b0e1d0b5ca9aab24b7e794dc1d1e81c25db commit bb7a6b0e1d0b5ca9aab24b7e794dc1d1e81c25db Author: chaopeng <chaopeng@chromium.org> Date: Thu Nov 24 00:43:51 2016 Document::updateHoverActiveState only cancel hover and active state when hitting native scrollbar This patch is change Document::updateHoverActiveState argument bool hitScrollbar to Scrollbar hitScrollbar and check hitScrollbar is native scrollbar. This patch can make `div:hover::-webkit-scrollbar-thumb` working correctly. BUG= 667206 Review-Url: https://codereview.chromium.org/2523903002 Cr-Commit-Position: refs/heads/master@{#434298} [modify] https://crrev.com/bb7a6b0e1d0b5ca9aab24b7e794dc1d1e81c25db/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/bb7a6b0e1d0b5ca9aab24b7e794dc1d1e81c25db/third_party/WebKit/Source/core/dom/Document.h [modify] https://crrev.com/bb7a6b0e1d0b5ca9aab24b7e794dc1d1e81c25db/third_party/WebKit/Source/core/input/EventHandler.cpp [modify] https://crrev.com/bb7a6b0e1d0b5ca9aab24b7e794dc1d1e81c25db/third_party/WebKit/Source/web/tests/WebFrameTest.cpp [add] https://crrev.com/bb7a6b0e1d0b5ca9aab24b7e794dc1d1e81c25db/third_party/WebKit/Source/web/tests/data/custom-scrollbar-hover.html
,
Nov 24 2016
,
Dec 7 2016
Issue 671893 has been merged into this issue.
,
Dec 7 2016
Ah, cool. It does not look like the fix in c7 has been merged to M56, probably we would want to do that?
,
Dec 7 2016
Yeah, we should merge this.
,
Dec 7 2016
,
Dec 7 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea3b2748f90de1afbca1477bf39a00642aba1268 commit ea3b2748f90de1afbca1477bf39a00642aba1268 Author: David Bokan <bokan@chromium.org> Date: Thu Dec 08 15:33:10 2016 Document::updateHoverActiveState only cancel hover and active state when hitting native scrollbar This patch is change Document::updateHoverActiveState argument bool hitScrollbar to Scrollbar hitScrollbar and check hitScrollbar is native scrollbar. This patch can make `div:hover::-webkit-scrollbar-thumb` working correctly. BUG= 667206 Review-Url: https://codereview.chromium.org/2523903002 Cr-Commit-Position: refs/heads/master@{#434298} (cherry picked from commit bb7a6b0e1d0b5ca9aab24b7e794dc1d1e81c25db) Review URL: https://codereview.chromium.org/2563483003 . Cr-Commit-Position: refs/branch-heads/2924@{#403} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/ea3b2748f90de1afbca1477bf39a00642aba1268/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/ea3b2748f90de1afbca1477bf39a00642aba1268/third_party/WebKit/Source/core/dom/Document.h [modify] https://crrev.com/ea3b2748f90de1afbca1477bf39a00642aba1268/third_party/WebKit/Source/core/input/EventHandler.cpp [modify] https://crrev.com/ea3b2748f90de1afbca1477bf39a00642aba1268/third_party/WebKit/Source/web/tests/WebFrameTest.cpp [add] https://crrev.com/ea3b2748f90de1afbca1477bf39a00642aba1268/third_party/WebKit/Source/web/tests/data/custom-scrollbar-hover.html
,
Dec 8 2016
Merged back to 56. Let me know if you're still seeing this.
,
Dec 14 2016
Tested the same on mac 10.11.6 chrome version 56.0.2924.28 - Hover effect is seen on vertical scroll bar in ‘Timeline’ section Please find the screencast Fix works as expected.
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kkaluri@chromium.org
, Nov 21 2016Owner: chaorenl@chromium.org
Status: Assigned (was: Unconfirmed)