New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 667204 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

reef-release: Failed to build autotest-deps-ltp-0.20150119-r14: fchmodat01.c:70:21: error: use of undeclared identifier '__NR_fchmodat'

Project Member Reported by drinkcat@chromium.org, Nov 21 2016

Issue description

See https://uberchromegw.corp.google.com/i/chromeos/builders/reef-release/builds/582/steps/BuildPackages%20%5Bafdo_use%5D/logs/stdio:

autotest-deps-ltp-0.20150119-r14: make[3]: Entering directory '/build/reef/tmp/portage/chromeos-base/autotest-deps-ltp-0.20150119-r14/work/autotest-deps-ltp-0.20150119/testcases/kernel/syscalls'
autotest-deps-ltp-0.20150119-r14: make[4]: Entering directory '/build/reef/tmp/portage/chromeos-base/autotest-deps-ltp-0.20150119-r14/work/autotest-deps-ltp-0.20150119/testcases/kernel/syscalls/fchmodat'
autotest-deps-ltp-0.20150119-r14: make -C "/build/reef/tmp/portage/chromeos-base/autotest-deps-ltp-0.20150119-r14/work/autotest-deps-ltp-0.20150119/testcases/kernel/include" -f "/build/reef/tmp/portage/chromeos-base/autotest-deps-ltp-0.20150119-r14/work/autotest-deps-ltp-0.20150119/testcases/kernel/include/Makefile" all
autotest-deps-ltp-0.20150119-r14: make[5]: Entering directory '/build/reef/tmp/portage/chromeos-base/autotest-deps-ltp-0.20150119-r14/work/autotest-deps-ltp-0.20150119/testcases/kernel/include'
autotest-deps-ltp-0.20150119-r14: make[5]: Nothing to be done for 'all'.
autotest-deps-ltp-0.20150119-r14: make[5]: Leaving directory '/build/reef/tmp/portage/chromeos-base/autotest-deps-ltp-0.20150119-r14/work/autotest-deps-ltp-0.20150119/testcases/kernel/include'
autotest-deps-ltp-0.20150119-r14: x86_64-cros-linux-gnu-clang -O2 -pipe -O2 -pipe -march=corei7 -g -fno-exceptions -fno-unwind-tables   -fno-asynchronous-unwind-tables  -clang-syntax -clang-syntax -g -O2 -fno-strict-aliasing -pipe -Wall -W -O2 -pipe -O2 -pipe -march=corei7 -g -fno-exceptions -fno-unwind-tables   -fno-asynchronous-unwind-tables  -clang-syntax -clang-syntax -Wold-style-definition  -I/build/reef/tmp/portage/chromeos-base/autotest-deps-ltp-0.20150119-r14/work/autotest-deps-ltp-0.20150119/testcases/kernel/include -I../../../../include -I../../../../include -Wl,-O1 -Wl,-O2 -Wl,--as-needed  -L../../../../lib  fchmodat01.c   -lltp -o fchmodat01
autotest-deps-ltp-0.20150119-r14: fchmodat01.c:70:9: warning: implicit declaration of function 'ltp_syscall' is
autotest-deps-ltp-0.20150119-r14:       invalid in C99 [-Wimplicit-function-declaration]
autotest-deps-ltp-0.20150119-r14:         return ltp_syscall(__NR_fchmodat, dirfd, filename, mode);
autotest-deps-ltp-0.20150119-r14:                ^
autotest-deps-ltp-0.20150119-r14: fchmodat01.c:70:21: error: use of undeclared identifier '__NR_fchmodat'; did you
autotest-deps-ltp-0.20150119-r14:       mean 'myfchmodat'?
autotest-deps-ltp-0.20150119-r14:         return ltp_syscall(__NR_fchmodat, dirfd, filename, mode);
autotest-deps-ltp-0.20150119-r14:                            ^~~~~~~~~~~~~
autotest-deps-ltp-0.20150119-r14:                            myfchmodat
autotest-deps-ltp-0.20150119-r14: fchmodat01.c:68:5: note: 'myfchmodat' declared here
autotest-deps-ltp-0.20150119-r14: int myfchmodat(int dirfd, const char *filename, mode_t mode)
autotest-deps-ltp-0.20150119-r14:     ^
autotest-deps-ltp-0.20150119-r14: 1 warning and 1 error generated.
autotest-deps-ltp-0.20150119-r14: make[4]: *** [<builtin>: fchmodat01] Error 1
autotest-deps-ltp-0.20150119-r14: make[4]: Leaving directory '/build/reef/tmp/portage/chromeos-base/autotest-deps-ltp-0.20150119-r14/work/autotest-deps-ltp-0.20150119/testcases/kernel/syscalls/fchmodat'
autotest-deps-ltp-0.20150119-r14: make[3]: *** [../../../include/mk/generic_trunk_target.inc:93: all] Error 2
autotest-deps-ltp-0.20150119-r14: make[3]: Leaving directory '/build/reef/tmp/portage/chromeos-base/autotest-deps-ltp-0.20150119-r14/work/autotest-deps-ltp-0.20150119/testcases/kernel/syscalls'
autotest-deps-ltp-0.20150119-r14: make[2]: *** [../../include/mk/generic_trunk_target.inc:93: all] Error 2
autotest-deps-ltp-0.20150119-r14: make[2]: Leaving directory '/build/reef/tmp/portage/chromeos-base/autotest-deps-ltp-0.20150119-r14/work/autotest-deps-ltp-0.20150119/testcases/kernel'
autotest-deps-ltp-0.20150119-r14: make[1]: *** [../include/mk/generic_trunk_target.inc:93: all] Error 2
autotest-deps-ltp-0.20150119-r14: make[1]: Leaving directory '/build/reef/tmp/portage/chromeos-base/autotest-deps-ltp-0.20150119-r14/work/autotest-deps-ltp-0.20150119/testcases'
autotest-deps-ltp-0.20150119-r14: make: *** [Makefile:114: testcases-all] Error 2

I do not see any obvious recent change that would cause this and AFAICT linux_syscall_numbers.h does include a macro that defines ltp_syscall.
 
Status: WontFix (was: Untriaged)
Recent builds do not seem to have this issue.
Status: Untriaged (was: WontFix)
Saw the same error today on kevin-paladin in CQ:
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8934435250524949712

> autotest-deps-ltp-0.20150119-r17: armv7a-cros-linux-gnueabihf-clang -O2 -pipe  -march=armv8-a+crc -mtune=cortex-a57.cortex-a53 -mfpu=crypto-neon-fp-armv8 -mfloat-abi=hard -g -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -g -O2 -fno-strict-aliasing -pipe -Wall -W  -O2 -pipe  -march=armv8-a+crc -mtune=cortex-a57.cortex-a53 -mfpu=crypto-neon-fp-armv8 -mfloat-abi=hard -g -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -Wold-style-definition  -I/build/kevin/tmp/portage/chromeos-base/autotest-deps-ltp-0.20150119-r17/work/autotest-deps-ltp-0.20150119/testcases/kernel/include -I../../../../include -I../../../../include -Wl,-O2 -Wl,--as-needed   -L../../../../lib  fchmodat01.c   -lltp -o fchmodat01
> autotest-deps-ltp-0.20150119-r17: fchmodat01.c:70:9: warning: implicit declaration of function 'ltp_syscall' is
> autotest-deps-ltp-0.20150119-r17:       invalid in C99 [-Wimplicit-function-declaration]
> autotest-deps-ltp-0.20150119-r17:         return ltp_syscall(__NR_fchmodat, dirfd, filename, mode);
> autotest-deps-ltp-0.20150119-r17:                ^
> autotest-deps-ltp-0.20150119-r17: fchmodat01.c:70:21: error: use of undeclared identifier '__NR_fchmodat'; did you
> autotest-deps-ltp-0.20150119-r17:       mean 'myfchmodat'?
> autotest-deps-ltp-0.20150119-r17:         return ltp_syscall(__NR_fchmodat, dirfd, filename, mode);
> autotest-deps-ltp-0.20150119-r17:                            ^~~~~~~~~~~~~
> autotest-deps-ltp-0.20150119-r17:                            myfchmodat
> autotest-deps-ltp-0.20150119-r17: fchmodat01.c:68:5: note: 'myfchmodat' declared here
> autotest-deps-ltp-0.20150119-r17: int myfchmodat(int dirfd, const char *filename, mode_t mode)
> autotest-deps-ltp-0.20150119-r17:     ^
> autotest-deps-ltp-0.20150119-r17: 1 warning and 1 error generated.
> autotest-deps-ltp-0.20150119-r17: make[4]: *** [<builtin>: fchmodat01] Error 1
Components: -Test Infra>Client>ChromeOS>Test
Cc: apronin@chromium.org yamaguchi@chromium.org briannorris@chromium.org
 Issue 892569  has been merged into this issue.
Owner: gu...@chromium.org
Status: Assigned (was: Untriaged)
Assigning to current Infra Deputy. This flake keeps recurring; we need to root-cause.
Labels: -Pri-3 Pri-2
upstream might have landed a change to the deps to fix the races, but we're on an ancient version at this point.  so it might be easier to stub out the call.

something like:
  https://chromium-review.googlesource.com/1264896
Owner: vapier@chromium.org
i posted a CL, but waiting for someone to review it
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 27

Labels: merge-merged-chromeos-20150119
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/ltp/+/08733aa7d62b171c667d3eb7e299aa7345053fa9

commit 08733aa7d62b171c667d3eb7e299aa7345053fa9
Author: Mike Frysinger <vapier@chromium.org>
Date: Sat Oct 27 00:19:11 2018

disable regen.sh due to possible build races

It looks like sometimes this generation script isn't atomic and races
with other compiles.  Since this script only exists to update the
linux_syscall_numbers.h header, and we commit that to git already,
there isn't a big need to run this all the time during build.

BUG= chromium:667204 
TEST=precq passes

Change-Id: I1918031c867b150bee22fbdb8ba2f2914185de04
Reviewed-on: https://chromium-review.googlesource.com/1264896
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>

[modify] https://crrev.com/08733aa7d62b171c667d3eb7e299aa7345053fa9/testcases/kernel/include/regen.sh

Status: Fixed (was: Assigned)
Should be fixed. We might kill it entirely anyway (bug 899051 - we've stopped building it for now).

Sign in to add a comment