New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 667190 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Long OOO (go/where-is-mgiuca)
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

compile failure on chromium.android/Android N5X Swarm Builder

Project Member Reported by mgiuca@chromium.org, Nov 21 2016

Issue description

compile failure on chromium.android/Android N5X Swarm Builder

Type: build-failure

Builders failed on: 
- Android N5X Swarm Builder: 
  https://build.chromium.org/p/chromium.android/builders/Android%20N5X%20Swarm%20Builder

Culprit: https://codereview.chromium.org/2510823005
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f3c8b5afb2cf8e682e49fb3bf52004340f5e877

commit 3f3c8b5afb2cf8e682e49fb3bf52004340f5e877
Author: mgiuca <mgiuca@chromium.org>
Date: Mon Nov 21 06:13:16 2016

Revert of Add TODO to BrowsingHistoryHandler regarding WebHistory deletion. (patchset #2 id:20001 of https://codereview.chromium.org/2510823005/ )

Reason for revert:
Compile failed (adds a new method definition without a declaration).

BUG= 667190 

Original issue's description:
> Add TODO to BrowsingHistoryHandler regarding WebHistory deletion.
>
> This CL is a followup to https://codereview.chromium.org/2455503004/.
>
> BUG=None
> NOTRY=true
>
> Committed: https://crrev.com/59b816025d660a3e4e42744654350b0d3145c7e7
> Cr-Commit-Position: refs/heads/master@{#433480}

TBR=msramek@chromium.org,calamity@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review-Url: https://codereview.chromium.org/2516283002
Cr-Commit-Position: refs/heads/master@{#433481}

[modify] https://crrev.com/3f3c8b5afb2cf8e682e49fb3bf52004340f5e877/chrome/browser/ui/webui/browsing_history_handler.cc

Comment 2 by piman@chromium.org, Nov 21 2016

Status: Fixed (was: Started)

Sign in to add a comment