New issue
Advanced search Search tips

Issue 667148 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Select dropdown blinks if value is changed while focused

Reported by porsa...@gmail.com, Nov 21 2016

Issue description

Chrome Version       : 54.0.2840.98 (64-bit) & Canary 57.0.2926.0 canary (64-bit)
URLs (if applicable) : https://jsfiddle.net/porsager/1r9qLqm3/
OS version               : 10.12.1
Behavior in Safari 3.x/4.x (if applicable): Doesn't blink
Behavior in Firefox 3.x (if applicable): Doesn't blink
Behavior in Chrome for Windows: Doesn't blink

What steps will reproduce the problem?
Setting option[value] (even to the same value) while having select open blinks select dropdown in Chrome

What is the expected result?
That the select doesn't blink

What happens instead?
The select blinks
 

Comment 1 by ajha@chromium.org, Nov 21 2016

Labels: M-57
Cc: msten...@opera.com rbasuvula@chromium.org
Components: UI
Labels: hasbisect
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
Tested in chrome stable #54.0.2840.98 and canary #57.0.2926.0 on Mac 10.11.6 and was able to reproduce the issue.
Below are the Bisect Details:

Bisect Info:
=============
Good Build: 52.0.2730.0(Revision : 392504)
Bad Build: 52.0.2733.0(Revision : 393005)

Bisect URL:
=========== 
You are probably looking for a change made after 392952 (known good), but no later than 392967 (first known bad).
CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/3e302bd544e4ac9ac1b119424a5b4d100340c70b..22863bca75277a5abce27fe961680e73171bb462


From the CL above, assigning the issue to the concern owner

@wangxianzhu: 
------------------
Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/1970653004

Note :  Not Able to reproduce the issue in Ubuntu 14.04 & Win 10.0

Cc: wangxianzhu@chromium.org
Owner: tkent@chromium.org
https://chromium.googlesource.com/chromium/src/+/1d5b6507ac2cbfdbb733cbefa1dbbce091b11a06 looks like the culprit.

tkent@ can you take a look?

Comment 4 by tkent@chromium.org, Nov 22 2016

Components: -UI Blink>Forms>Select
Labels: -M-57
Owner: ----
Status: Available (was: Assigned)
This is almost an intentional behavior for now.  It's good to have an optimization to skip popup recreation if DOM change isn't change OPTION values.

Cc: -msten...@opera.com -wangxianzhu@chromium.org

Comment 6 by tkent@chromium.org, Dec 14 2016

Owner: tkent@chromium.org
Status: Started (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40feeb134491de74bf14d3fa8aa2dfe05a28d31e

commit 40feeb134491de74bf14d3fa8aa2dfe05a28d31e
Author: tkent <tkent@chromium.org>
Date: Wed Dec 14 08:28:21 2016

SELECT element: Do not update popup content if CharacterData or attribute value is not changed.

BUG= 667148 

Review-Url: https://codereview.chromium.org/2568333004
Cr-Commit-Position: refs/heads/master@{#438462}

[modify] https://crrev.com/40feeb134491de74bf14d3fa8aa2dfe05a28d31e/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Comment 8 by tkent@chromium.org, Dec 14 2016

Labels: M-57
Status: Fixed (was: Started)

Sign in to add a comment