New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 667144 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Long OOO (go/where-is-mgiuca)
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

non-fast-scrollable-visibility-change.html

Project Member Reported by mgiuca@chromium.org, Nov 21 2016

Issue description

Comment 1 by mgiuca@chromium.org, Nov 21 2016

From build logs on linux-trusty at r433235:

10:12:47.391 16874   [1:1:1118/101246:1104527631:ERROR:PaintController.cpp(742)] "" under-invalidation: display item changed
10:12:47.391 16874   [1:1:1118/101246:1104527767:ERROR:PaintController.cpp(748)] Run debug build to get more details.
10:12:47.391 16874   [1:1:1118/101246:1104527827:ERROR:PaintController.cpp(750)] See http://crbug.com/619103.
10:12:47.391 16874   [1:1:1118/101246:1104527882:FATAL:PaintController.cpp(813)] Check failed: false. 
10:12:47.392 16874   #0 0x00000143645e base::debug::StackTrace::StackTrace()
10:12:47.392 16874   #1 0x000001444ecb logging::LogMessage::~LogMessage()
10:12:47.392 16874   #2 0x0000022860e2 blink::PaintController::checkUnderInvalidation()
10:12:47.392 16874   #3 0x000002283800 blink::DrawingRecorder::~DrawingRecorder()
10:12:47.392 16874   #4 0x000002bee278 blink::ViewPainter::paintBoxDecorationBackground()
10:12:47.392 16874   #5 0x000002ad59bd blink::LayoutView::paintBoxDecorationBackground()
10:12:47.392 16874   #6 0x000002b9f82c blink::BlockPainter::paintObject()
10:12:47.392 16874   #7 0x000002a1f94d blink::LayoutBlock::paintObject()
10:12:47.392 16874   #8 0x000002bed6e3 blink::ViewPainter::paint()
10:12:47.392 16874   #9 0x000002ad59ad blink::LayoutView::paint()
10:12:47.392 16874   #10 0x000002bd3204 blink::PaintLayerPainter::paintFragmentWithPhase()
10:12:47.392 16874   #11 0x000002bd12ce blink::PaintLayerPainter::paintLayerContents()
10:12:47.392 16874   #12 0x000002af209d blink::CompositedLayerMapping::doPaintTask()
10:12:47.392 16874   #13 0x000002af2b1f blink::CompositedLayerMapping::paintContents()
10:12:47.392 16874   #14 0x000002278a5b blink::GraphicsLayer::paintWithoutCommit()
10:12:47.392 16874   #15 0x000002278707 blink::GraphicsLayer::paint()
10:12:47.392 16874   #16 0x000002824384 blink::FrameView::synchronizedPaintRecursively()
10:12:47.392 16874   #17 0x0000028243db blink::FrameView::synchronizedPaintRecursively()
10:12:47.392 16874   #18 0x0000028243db blink::FrameView::synchronizedPaintRecursively()
10:12:47.392 16874   #19 0x0000028243db blink::FrameView::synchronizedPaintRecursively()
10:12:47.392 16874   #20 0x0000028243db blink::FrameView::synchronizedPaintRecursively()
10:12:47.392 16874   #21 0x000002823ad7 blink::FrameView::synchronizedPaint()
10:12:47.392 16874   #22 0x000002822ca4 blink::FrameView::updateLifecyclePhasesInternal()
10:12:47.392 16874   #23 0x000002b889ca blink::PageAnimator::updateAllLifecyclePhases()
10:12:47.392 16874   #24 0x0000023a37cd blink::WebViewImpl::updateAllLifecyclePhases()
10:12:47.392 16874   #25 0x00000140ecde content::BlinkTestRunner::TestFinished()
10:12:47.392 16874   #26 0x0000033503a0 test_runner::TestRunner::NotifyDone()
10:12:47.392 16874   #27 0x000003356721 gin::internal::Dispatcher<>::DispatchToCallback()
10:12:47.392 16874   #28 0x0000006fe5ef v8::internal::FunctionCallbackArguments::Call()
10:12:47.392 16874   #29 0x00000077760d v8::internal::(anonymous namespace)::HandleApiCallHelper<>()
10:12:47.392 16874   #30 0x000000776b15 v8::internal::Builtin_Impl_HandleApiCall()
10:12:47.392 16874   #31 0x23cd251843a7 <unknown>
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/754b0c5c59d039c70bd6fea540af4b706ea39c77

commit 754b0c5c59d039c70bd6fea540af4b706ea39c77
Author: mgiuca <mgiuca@chromium.org>
Date: Mon Nov 21 02:19:08 2016

Revert of Don't early out recursion into PaintLayerChildren when computing composited bounds. (patchset #6 id:100001 of https://codereview.chromium.org/2502833002/ )

Reason for revert:
Speculative revert for  https://crbug.com/667144 .

A checkfail in PaintController.cpp started happening reliably in between r433228
and r433235. This CL looks closely related.

BUG= 667144 

Original issue's description:
> Don't early out recursion into PaintLayerChildren when computing composited bounds.
>
> PaintLayer::boundingBoxForCompositing recursively computes the union of the
> bounds of a root PaintLayer and its non-comositing descendants. Previously, in PaintLayer::boundingBoxForCompositing, there was code that would avoid recursing
> into PaintLayer children if the PaintLayer was clipped. This is incorrect if there
> are any PaintLayer descendants that have different clipping ancestors than
> the current PaintLayer.
>
> Also fixed a bug that transform-related properties were not considered containing
> blocks for clipping of fixed-position children.
>
> BUG= 618046 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/b33e49953078995f1cd28663a8a8b43012ac2eb0
> Cr-Commit-Position: refs/heads/master@{#433232}

TBR=wangxianzhu@chromium.org,chrishtr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 618046 

Review-Url: https://codereview.chromium.org/2517863002
Cr-Commit-Position: refs/heads/master@{#433468}

[modify] https://crrev.com/754b0c5c59d039c70bd6fea540af4b706ea39c77/third_party/WebKit/LayoutTests/compositing/contents-opaque/filter-expected.txt
[delete] https://crrev.com/de0cc48f37dd53a19b0d14dd998b913f06c88599/third_party/WebKit/LayoutTests/paint/overflow/non-composited-fixed-position-descendant-expected.png
[delete] https://crrev.com/de0cc48f37dd53a19b0d14dd998b913f06c88599/third_party/WebKit/LayoutTests/paint/overflow/non-composited-fixed-position-descendant-expected.txt
[delete] https://crrev.com/de0cc48f37dd53a19b0d14dd998b913f06c88599/third_party/WebKit/LayoutTests/paint/overflow/non-composited-fixed-position-descendant.html
[modify] https://crrev.com/754b0c5c59d039c70bd6fea540af4b706ea39c77/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/754b0c5c59d039c70bd6fea540af4b706ea39c77/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
[modify] https://crrev.com/754b0c5c59d039c70bd6fea540af4b706ea39c77/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp

Comment 4 by mgiuca@chromium.org, Nov 21 2016

Cc: chrishtr@chromium.org
Status: Fixed (was: Started)
Yep, this is fixed now (as of r433468).

Comment 5 by mgiuca@chromium.org, Nov 21 2016

 Issue 667061  has been merged into this issue.
Issue 667008 has been merged into this issue.

Sign in to add a comment