non-fast-scrollable-visibility-change.html |
|
Issue descriptionVersion: r433235 OS: All Flakiness dashboard shows crashing starts very clearly between r433228 to r433235 on all platforms. https://chromium.googlesource.com/chromium/src/+log/d6e246642696f61db822e9170b92a61e598de303%5E..7f6421b1628a15833196ff7cf1fefbe5fcd69558?pretty=fuller
,
Nov 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/754b0c5c59d039c70bd6fea540af4b706ea39c77 commit 754b0c5c59d039c70bd6fea540af4b706ea39c77 Author: mgiuca <mgiuca@chromium.org> Date: Mon Nov 21 02:19:08 2016 Revert of Don't early out recursion into PaintLayerChildren when computing composited bounds. (patchset #6 id:100001 of https://codereview.chromium.org/2502833002/ ) Reason for revert: Speculative revert for https://crbug.com/667144 . A checkfail in PaintController.cpp started happening reliably in between r433228 and r433235. This CL looks closely related. BUG= 667144 Original issue's description: > Don't early out recursion into PaintLayerChildren when computing composited bounds. > > PaintLayer::boundingBoxForCompositing recursively computes the union of the > bounds of a root PaintLayer and its non-comositing descendants. Previously, in PaintLayer::boundingBoxForCompositing, there was code that would avoid recursing > into PaintLayer children if the PaintLayer was clipped. This is incorrect if there > are any PaintLayer descendants that have different clipping ancestors than > the current PaintLayer. > > Also fixed a bug that transform-related properties were not considered containing > blocks for clipping of fixed-position children. > > BUG= 618046 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Committed: https://crrev.com/b33e49953078995f1cd28663a8a8b43012ac2eb0 > Cr-Commit-Position: refs/heads/master@{#433232} TBR=wangxianzhu@chromium.org,chrishtr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 618046 Review-Url: https://codereview.chromium.org/2517863002 Cr-Commit-Position: refs/heads/master@{#433468} [modify] https://crrev.com/754b0c5c59d039c70bd6fea540af4b706ea39c77/third_party/WebKit/LayoutTests/compositing/contents-opaque/filter-expected.txt [delete] https://crrev.com/de0cc48f37dd53a19b0d14dd998b913f06c88599/third_party/WebKit/LayoutTests/paint/overflow/non-composited-fixed-position-descendant-expected.png [delete] https://crrev.com/de0cc48f37dd53a19b0d14dd998b913f06c88599/third_party/WebKit/LayoutTests/paint/overflow/non-composited-fixed-position-descendant-expected.txt [delete] https://crrev.com/de0cc48f37dd53a19b0d14dd998b913f06c88599/third_party/WebKit/LayoutTests/paint/overflow/non-composited-fixed-position-descendant.html [modify] https://crrev.com/754b0c5c59d039c70bd6fea540af4b706ea39c77/third_party/WebKit/Source/core/paint/PaintLayer.cpp [modify] https://crrev.com/754b0c5c59d039c70bd6fea540af4b706ea39c77/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp [modify] https://crrev.com/754b0c5c59d039c70bd6fea540af4b706ea39c77/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp
,
Nov 21 2016
,
Nov 21 2016
,
Nov 21 2016
Issue 667061 has been merged into this issue.
,
Nov 22 2016
Issue 667008 has been merged into this issue. |
|
►
Sign in to add a comment |
|
Comment 1 by mgiuca@chromium.org
, Nov 21 2016