Clicking keyboard toggle button will make the system IME settings button disappeared. |
||||||||
Issue descriptionChrome Version: 57.0.2926.0 canary OS: Chrome OS Steps to reproduce: 1. In TouchView, plugge in an external keyboard. 2. Open the IME detailed view in the system menu, a 'Disable on-screen keyboard' toggle will be shown. 3. Click on the keyboard toggle, What is the expected result? The settings button on the IME menu title row will not change. What happens instead? The settings button on the IME menu title row disappeared. Please use labels and text to provide additional information.
,
Nov 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ac84d7c1ef8eb9c8d1ab59608975de1db3c7821 commit 4ac84d7c1ef8eb9c8d1ab59608975de1db3c7821 Author: azurewei <azurewei@chromium.org> Date: Wed Nov 23 02:24:36 2016 Reset settings button when update the list view. We need to reset the settings button object when updating the IME detailed view, otherwise there may has memory leak, and checking if(settings_button_) could be true but the IME view is updated without drawing the settings button. BUG= 667105 TEST=Verified on Clapper. Review-Url: https://codereview.chromium.org/2521443002 Cr-Commit-Position: refs/heads/master@{#434083} [modify] https://crrev.com/4ac84d7c1ef8eb9c8d1ab59608975de1db3c7821/ash/common/system/chromeos/ime_menu/ime_list_view.h [modify] https://crrev.com/4ac84d7c1ef8eb9c8d1ab59608975de1db3c7821/ash/common/system/ime/tray_ime_chromeos.cc
,
Nov 28 2016
,
Nov 28 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 28 2016
Let's leave open until the merge into 56 is complete. Verified on 57.0.2933.0 canary, will perform the merge shortly.
,
Nov 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cf3948a71dbb62220c262d1d98b9e378efa46da commit 6cf3948a71dbb62220c262d1d98b9e378efa46da Author: Terry Anderson <tdanderson@chromium.org> Date: Mon Nov 28 21:25:00 2016 Reset settings button when update the list view. We need to reset the settings button object when updating the IME detailed view, otherwise there may has memory leak, and checking if(settings_button_) could be true but the IME view is updated without drawing the settings button. BUG= 667105 TEST=Verified on Clapper. Review-Url: https://codereview.chromium.org/2521443002 Cr-Commit-Position: refs/heads/master@{#434083} (cherry picked from commit 4ac84d7c1ef8eb9c8d1ab59608975de1db3c7821) Review URL: https://codereview.chromium.org/2533793004 . Cr-Commit-Position: refs/branch-heads/2924@{#128} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/6cf3948a71dbb62220c262d1d98b9e378efa46da/ash/common/system/chromeos/ime_menu/ime_list_view.h [modify] https://crrev.com/6cf3948a71dbb62220c262d1d98b9e378efa46da/ash/common/system/ime/tray_ime_chromeos.cc
,
Nov 28 2016
,
Nov 29 2016
,
Jan 5 2017
Verified on ChromeOS 9000.50.0, 56.0.2924.53 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by tdander...@chromium.org
, Nov 22 2016Status: Started (was: Assigned)