New issue
Advanced search Search tips

Issue 667086 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add Use counter for Link rel=serviceworker headers

Project Member Reported by mek@chromium.org, Nov 20 2016

Issue description

We should have a use counter for this.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c76cfaf64b27534abe2663b2a1768737d64d4f9

commit 9c76cfaf64b27534abe2663b2a1768737d64d4f9
Author: mek <mek@chromium.org>
Date: Sun Nov 20 03:59:06 2016

Add a use counter for Link rel=serviceworker headers.

Even though these link headers aren't processed in blink, this is still
the most sensible place for a use counter for these.

BUG= 582310 , 667086 

Review-Url: https://codereview.chromium.org/2513183002
Cr-Commit-Position: refs/heads/master@{#433444}

[modify] https://crrev.com/9c76cfaf64b27534abe2663b2a1768737d64d4f9/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/9c76cfaf64b27534abe2663b2a1768737d64d4f9/third_party/WebKit/Source/core/loader/LinkLoader.cpp
[modify] https://crrev.com/9c76cfaf64b27534abe2663b2a1768737d64d4f9/tools/metrics/histograms/histograms.xml

Comment 2 by mek@chromium.org, Nov 22 2016

Components: Blink>ServiceWorker
Labels: Merge-Request-56
I'd like to backport this use counter to M56

Comment 3 by dimu@chromium.org, Nov 22 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 30 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by mek@chromium.org, Nov 30 2016

Labels: -Merge-Approved-56 merge-merged-2924
This was merged to 2924, not sure why bugdroid didn't update the issue.

Comment 6 by mek@chromium.org, Nov 30 2016

Status: Fixed (was: Started)

Sign in to add a comment