WIP @ http://crrev.com/2519723002

Would it be possible to support Web Payments in WebView somehow, though? In our Opera Mini product for Android we use a regular WebView to display pages, but we would definitely be interested in supporting Web Payments.

Is it possible to enable/disable Web Payments dynamically for the WebView? If so, we could have it disabled by default, but enabled if someone attaches an implementation of some kind of WebPaymentsUIHandler.

If you think this is feasible, but you don't have time to do it, I could probably take a look at it.

We'd need to add callbacks to the WebView API, which we can't do outside of the Android release cycle, and won't be supported on older OS versions. There's no way for an app on a current version to provide any UI/data for this feature.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04ae1ea7ce962ae6e1fd81b5a2efa0b45582467b

commit 04ae1ea7ce962ae6e1fd81b5a2efa0b45582467b
Author: rouslan <rouslan@chromium.org>
Date: Mon Nov 21 14:41:33 2016

Disable Web Payments in WebView

Web Payments API requires Chrome UI, which is not available in WebView.
This patch disabled Web Payments feature in WebView, so that
feature-detection for "window.PaymentRequest" works as expected in
JavaScript.

BUG= 667069 

Review-Url: https://codereview.chromium.org/2519723002
Cr-Commit-Position: refs/heads/master@{#433540}

[modify] https://crrev.com/04ae1ea7ce962ae6e1fd81b5a2efa0b45582467b/android_webview/browser/command_line_helper.cc
[modify] https://crrev.com/04ae1ea7ce962ae6e1fd81b5a2efa0b45582467b/android_webview/browser/command_line_helper.h
[modify] https://crrev.com/04ae1ea7ce962ae6e1fd81b5a2efa0b45582467b/android_webview/browser/command_line_helper_unittest.cc
[modify] https://crrev.com/04ae1ea7ce962ae6e1fd81b5a2efa0b45582467b/android_webview/lib/main/aw_main_delegate.cc

tommyt@, torne@: If there's interest in adding PaymentRequest to WebView, I'm happy to have a chat, review your design doc, and review your code. I had to disable PaymentRequest in WebView because WebView does not have Chrome UI, which is required for user to approve the payment. So, the website would assume that PaymentRequest is available because "window.PaymentRequest" was defined, but calling the API would always return an error message.

Your change meets the bar and is auto-approved for M55 (branch: 2883)

Your change meets the bar and is auto-approved for M56 (branch: 2924)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7f3ee389025f2344b8e582865fcd5d23e200437

commit d7f3ee389025f2344b8e582865fcd5d23e200437
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Mon Nov 21 19:15:16 2016

[Merge M-56] Disable Web Payments in WebView

Web Payments API requires Chrome UI, which is not available in WebView.
This patch disabled Web Payments feature in WebView, so that
feature-detection for "window.PaymentRequest" works as expected in
JavaScript.

BUG= 667069 

Review-Url: https://codereview.chromium.org/2519723002
Cr-Commit-Position: refs/heads/master@{#433540}
(cherry picked from commit 04ae1ea7ce962ae6e1fd81b5a2efa0b45582467b)

Review URL: https://codereview.chromium.org/2522603002 .

Cr-Commit-Position: refs/branch-heads/2924@{#33}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/d7f3ee389025f2344b8e582865fcd5d23e200437/android_webview/browser/command_line_helper.cc
[modify] https://crrev.com/d7f3ee389025f2344b8e582865fcd5d23e200437/android_webview/browser/command_line_helper.h
[modify] https://crrev.com/d7f3ee389025f2344b8e582865fcd5d23e200437/android_webview/browser/command_line_helper_unittest.cc
[modify] https://crrev.com/d7f3ee389025f2344b8e582865fcd5d23e200437/android_webview/lib/main/aw_main_delegate.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3ce76a4af496fa07a78ab50f9990b94ea01fdca

commit e3ce76a4af496fa07a78ab50f9990b94ea01fdca
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Mon Nov 21 19:23:02 2016

[Merge M-55] Disable Web Payments in WebView

Web Payments API requires Chrome UI, which is not available in WebView.
This patch disabled Web Payments feature in WebView, so that
feature-detection for "window.PaymentRequest" works as expected in
JavaScript.

BUG= 667069 

Review-Url: https://codereview.chromium.org/2519723002
Cr-Commit-Position: refs/heads/master@{#433540}
(cherry picked from commit 04ae1ea7ce962ae6e1fd81b5a2efa0b45582467b)

Review URL: https://codereview.chromium.org/2520053002 .

Cr-Commit-Position: refs/branch-heads/2883@{#632}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/e3ce76a4af496fa07a78ab50f9990b94ea01fdca/android_webview/browser/command_line_helper.cc
[modify] https://crrev.com/e3ce76a4af496fa07a78ab50f9990b94ea01fdca/android_webview/browser/command_line_helper.h
[modify] https://crrev.com/e3ce76a4af496fa07a78ab50f9990b94ea01fdca/android_webview/browser/command_line_helper_unittest.cc
[modify] https://crrev.com/e3ce76a4af496fa07a78ab50f9990b94ea01fdca/android_webview/lib/main/aw_main_delegate.cc

Verified feature not available on Nexus 6 NRD91N 55.0.2883.63

The WebView exposed interface check should ideally have caught that we were exposing this new interface in webview and triggered someone to check whether this was okay or not, at the time that it was landed on trunk. Tim, did we miss this one?

torne@, web payments is marked "experimental" by default [1] and is manually enabled on Android only [2]. Is this setup causing issues?

[1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in?rcl=0&l=175

[2] https://cs.chromium.org/chromium/src/content/child/runtime_features.cc?rcl=0&l=303

I don't think so, we run the test on the actual WebView, so any interface that's actually exposed on window should show up regardless of the mechanism it's configured with.

May be relevant: https://bugs.chromium.org/p/chromium/issues/detail?id=666495

did it launch as part of stable blink interfaces? It should indeed have been caught by the bots we have..

Verified feature not available on Samsung 6 edge LRX22G, WebView version 56.0.2924.13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/948317e5fe39e679b776bfd732dd50c4215bd191

commit 948317e5fe39e679b776bfd732dd50c4215bd191
Author: johnme <johnme@chromium.org>
Date: Fri May 05 15:59:04 2017

[WebView global interface listing] Mark Web Payments as not exposed

Fix WebViewLayoutTest#testWebViewIncludedStableInterfaces which is
currently failing because the Web Payments API is not currently
supported on WebView ( crbug.com/667069 ), but was missing from the list
of APIs expected to be missing.

BUG= 667069 , 717914 
TBR=rouslan@chromium.org,zkoch@chromium.org,timvolodine@chromium.org
NOTRY=true
SKIPTREECHECKS=true

Review-Url: https://codereview.chromium.org/2862583009
Cr-Commit-Position: refs/heads/master@{#469665}

[modify] https://crrev.com/948317e5fe39e679b776bfd732dd50c4215bd191/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb5d94cee477904632b89d75e095673fa9569872

commit eb5d94cee477904632b89d75e095673fa9569872
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Tue Sep 18 12:03:14 2018

Update not-webview-exposed.txt for PaymentResponse inheritance change

PaymentResponse was recently made to inherit from EventTarget:
https://chromium-review.googlesource.com/c/chromium/src/+/1206750

At the time the webexposed tests were disabled, but now reenbled:
https://chromium-review.googlesource.com/c/chromium/src/+/1223149

That CL update global-interface-listing-expected.txt for the change,
but WebViewLayoutTest also need updating now.

TBR=timvolodine@chromium.org

Bug:  667069 , 861704, 883914
Change-Id: I33ac483d8ee11747405505e3dcf1b7a48fbe1dfa
Reviewed-on: https://chromium-review.googlesource.com/1227128
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#592004}
[modify] https://crrev.com/eb5d94cee477904632b89d75e095673fa9569872/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt