New issue
Advanced search Search tips

Issue 667060 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 665296
Owner: ----
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"BrowserFocusTest.FocusOnNavigate" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Nov 19 2016

Issue description

"BrowserFocusTest.FocusOnNavigate" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKwsSBUZsYWtlIiBCcm93c2VyRm9jdXNUZXN0LkZvY3VzT25OYXZpZ2F0ZQw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

This flaky test/step was previously tracked in  issue 665317 .
 
Mergedinto: 665296
Status: Duplicate (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b86b0a08c9b0430189197e175466578a147195de

commit b86b0a08c9b0430189197e175466578a147195de
Author: David Benjamin <davidben@chromium.org>
Date: Thu Sep 21 16:55:36 2017

Remove unnecessary SPKI parameter to CreateFromEncryptedPrivateKeyInfo.

This hasn't been used for a while. We should remove this function
altogether, but components/gcm_driver hasn't switched to the more
efficient format yet. Meanwhile, we can still simplify some stuff.

This removes all uses of public_key_x509 in components/gcm_crypto, but
it does not stop computing it. That will be done in a follow-up CL.

Bug:  667060 
Change-Id: I6d5f952c4fd822152f0aa142bafe59be933e393f
Reviewed-on: https://chromium-review.googlesource.com/667060
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503473}
[modify] https://crrev.com/b86b0a08c9b0430189197e175466578a147195de/components/gcm_driver/crypto/gcm_crypto_test_helpers.cc
[modify] https://crrev.com/b86b0a08c9b0430189197e175466578a147195de/components/gcm_driver/crypto/gcm_encryption_provider.cc
[modify] https://crrev.com/b86b0a08c9b0430189197e175466578a147195de/components/gcm_driver/crypto/gcm_encryption_provider_unittest.cc
[modify] https://crrev.com/b86b0a08c9b0430189197e175466578a147195de/components/gcm_driver/crypto/gcm_message_cryptographer_unittest.cc
[modify] https://crrev.com/b86b0a08c9b0430189197e175466578a147195de/components/gcm_driver/crypto/p256_key_util.cc
[modify] https://crrev.com/b86b0a08c9b0430189197e175466578a147195de/components/gcm_driver/crypto/p256_key_util.h
[modify] https://crrev.com/b86b0a08c9b0430189197e175466578a147195de/components/gcm_driver/crypto/p256_key_util_unittest.cc
[modify] https://crrev.com/b86b0a08c9b0430189197e175466578a147195de/crypto/ec_private_key.cc
[modify] https://crrev.com/b86b0a08c9b0430189197e175466578a147195de/crypto/ec_private_key.h
[modify] https://crrev.com/b86b0a08c9b0430189197e175466578a147195de/crypto/ec_private_key_unittest.cc
[modify] https://crrev.com/b86b0a08c9b0430189197e175466578a147195de/net/extras/sqlite/sqlite_channel_id_store_unittest.cc

Sign in to add a comment