New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 667052 link

Starred by 3 users
Status: WontFix
Owner:
skobes@chromium.org
Closed: Nov 2016
Cc:
█ ymalik@chromium.org
skobes@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Compat

Blocking:
issue 558575



Sign in to add a comment

Expand scroll anchoring test coverage?

Project Member Reported by rbyers@chromium.org, Nov 19 2016 
Scroll anchoring ( issue 558575 ) has some pretty complex algorithms (https://skobes.github.io/ScrollAnchoring/).  Unless I'm missing something it looks like our test coverage of those algorithms (https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/layout/scroll-anchoring/) is not very complete.  For example, I can't find a single test for the behavior of the overflow-anchor property (landed here: https://codereview.chromium.org/2145823002).

Given all the user excitement about this feature shipping in Chrome, I suspect other browsers are going to want to implement it before too long.  To help them do that interoperably we'd ideally have a really thorough test suite which we could upstream to web-platform-test (https://github.com/skobes/ScrollAnchoring/issues/3).

Comment 1 by skobes@chromium.org, Nov 20 2016 

Most of the tests are in ScrollAnchorTest.  We have three test cases that use the overflow-anchor API:

ScrollAnchorTest.OptOutElement
ScrollAnchorTest.OptOutBody
ScrollAnchorTest.OptOutScrollingDiv

I think most of them are not too difficult to upstream.

Comment 2 by rbyers@chromium.org, Nov 21 2016 

I'm sorry, I totally missed those tests!  I guess I only grepped layoutTests for overflow-anchor - should have known better :-(

I didn't study the coverage in detail.  If we upstreamed what we have, do you think it would be enough to validate another implementation was compatible in practice with what sites are likely to come to depend on?  If so, we should close this WontFix and just track upstreaming in https://github.com/skobes/ScrollAnchoring/issues/3.

Comment 3 by e...@chromium.org, Nov 21 2016

Labels: -Type-Bug Type-Compat
Owner: skobes@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 4 by skobes@chromium.org, Nov 22 2016

Status: WontFix (was: Assigned)
Re #2: Yes I think we have sufficient coverage for that.  Closing as suggested.

Comment 5 by rbyers@chromium.org, Nov 22 2016 

Great, thank you!  Sorry again for the noise!
►

Sign in to add a comment