New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 667051 link

Starred by 3 users
Status: Verified
Owner:
isandrk@chromium.org
Closed: Nov 2016
Cc:
█ sduraisamy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 656511



Sign in to add a comment

Adjust Public Session login pod for extended APIs

Project Member Reported by isandrk@chromium.org, Nov 19 2016 
A bunch of new APIs are being whitelisted in Public Sessions, display notification to user about possible security and privacy consequences.

Here are the approximate mocks of the new design https://folio.googleplex.com/cros-public-session-ui

Comment 1 by isandrk@chromium.org, Nov 19 2016

Description: Show this description

Comment 2 by achuith@chromium.org, Nov 21 2016

Labels: -Pri-3 Pri-2

Comment 4 by isandrk@chromium.org, Nov 23 2016

Cc: sduraisamy@chromium.org
Labels: Merge-Request-56
Status: Fixed (was: Started)

Comment 5 by sduraisamy@chromium.org, Nov 23 2016

Blocking: 656511

Comment 6 by sduraisamy@chromium.org, Nov 23 2016

Labels: M-56

Comment 7 by dimu@chromium.org, Nov 24 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 24 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe0e2db2dc578ea67a59b90b870857277ae2b2b4

commit fe0e2db2dc578ea67a59b90b870857277ae2b2b4
Author: Andrew Wilson <atwilson@chromium.org>
Date: Thu Nov 24 15:28:25 2016

PS - Adjusting Public Session login pod for expanded whitelisting

Approximate mocks of the new design https://folio.googleplex.com/cros-public-session-ui

BUG= 667051 

Review-Url: https://codereview.chromium.org/2516903002
Cr-Commit-Position: refs/heads/master@{#434153}
(cherry picked from commit 12f48eb6682abca50f059b65beebc31d49fad3f4)

Review URL: https://codereview.chromium.org/2532503002 .

Cr-Commit-Position: refs/branch-heads/2924@{#94}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/fe0e2db2dc578ea67a59b90b870857277ae2b2b4/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/fe0e2db2dc578ea67a59b90b870857277ae2b2b4/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
[modify] https://crrev.com/fe0e2db2dc578ea67a59b90b870857277ae2b2b4/ui/login/account_picker/user_pod_row.css
[modify] https://crrev.com/fe0e2db2dc578ea67a59b90b870857277ae2b2b4/ui/login/account_picker/user_pod_row.js
[modify] https://crrev.com/fe0e2db2dc578ea67a59b90b870857277ae2b2b4/ui/login/account_picker/user_pod_template.html

Comment 9 by krishna...@chromium.org, Jan 26 2017

Status: Verified (was: Fixed)
This has been verified on R56.
►

Sign in to add a comment