Add histograms for WebGL contexts' GPU resource consumption |
|||||||
Issue descriptionIn order to better understand any correlations between GPU process crashes on Android from the system OOM killer, and high GPU resource consumption by WebGL, two histograms are needed: 1) One which periodically measures the GPU resource consumption by WebGL contexts; for example, once every minute, and when the context is destroyed. 2) One which measures the GPU resource consumption by WebGL contexts when Android sends its low-memory notification to the GPU process. It looks like all of the code is already in place for this in the form of the GpuMemoryTrackingGroup and GpuCommandBufferMemoryTracker classes, and that the queries are cheap.
,
Dec 6 2016
,
Dec 7 2016
,
Dec 13 2016
Is there a good person to assign this to?
,
Dec 13 2016
Well for now.
,
Dec 14 2016
Putting together a CL now.
,
Dec 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b10572ad91a13dfe5b6faef18990d8464714e666 commit b10572ad91a13dfe5b6faef18990d8464714e666 Author: ericrk <ericrk@chromium.org> Date: Wed Dec 28 19:54:04 2016 Add UMAs for GL context memory usage Adds 6 new UMA metrics which log GL context memory. Memory is logged separately for WebGL and GLES contexts. Additionally, logging occurs at three points - periodically (every 1s), at shutdown, and when the GPU process gets a CRITICAL memory pressure signal. The new histograms are: GPU.ContextMemory.WebGL.Periodic GPU.ContextMemory.WebGL.Shutdown GPU.ContextMemory.WebGL.Pressure GPU.ContextMemory.GLES.Periodic GPU.ContextMemory.GLES.Shutdown GPU.ContextMemory.GLES.Pressure BUG= 667013 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2577843002 Cr-Commit-Position: refs/heads/master@{#440882} [modify] https://crrev.com/b10572ad91a13dfe5b6faef18990d8464714e666/gpu/ipc/service/gpu_command_buffer_stub.cc [modify] https://crrev.com/b10572ad91a13dfe5b6faef18990d8464714e666/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/b10572ad91a13dfe5b6faef18990d8464714e666/tools/metrics/histograms/pretty_print.py
,
Jan 9 2017
Hi ericrk@. Does this issue need more work? Is it still P1? Thanks.
,
Jan 11 2017
Histograms are landed and seem to be working. Closing this issue out.
,
Jun 20 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by kbr@chromium.org
, Nov 19 2016