Issue 667007 link

Starred by 3 users

Issue metadata

Status:	Fixed
Owner:	panicker@chromium.org
Closed:	Dec 2016
Cc:	panicker@chromium.org yoavweiss@chromium.org npm@chromium.org
Components:	Blink>PerformanceAPIs
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

Blocking:
issue 635596

Long Tasks API: Replace culprit domWindow with iframe attrs

Project Member Reported by panicker@chromium.org, Nov 19 2016

Issue description

Replace culprit domWindow with specific iframe attrs: src, id, name
Turned out that domWindow was not actually helpful in identifying the frame.

Truncate id and name to 100(?) chars. In particular name is abused in some cases to send entire contents of Ads(!)

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aee80e88c92958c951dc21309f31a64724dbb856

commit aee80e88c92958c951dc21309f31a64724dbb856
Author: panicker <panicker@chromium.org>
Date: Tue Nov 22 03:48:35 2016

Long Tasks API attribution: replace DOMWindow with iframe attrs: src, id, name

BUG= 667007 

Review-Url: https://codereview.chromium.org/2515993002
Cr-Commit-Position: refs/heads/master@{#433779}

[modify] https://crrev.com/aee80e88c92958c951dc21309f31a64724dbb856/third_party/WebKit/Source/core/timing/Performance.cpp
[modify] https://crrev.com/aee80e88c92958c951dc21309f31a64724dbb856/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
[modify] https://crrev.com/aee80e88c92958c951dc21309f31a64724dbb856/third_party/WebKit/Source/core/timing/PerformanceBase.h
[modify] https://crrev.com/aee80e88c92958c951dc21309f31a64724dbb856/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
[modify] https://crrev.com/aee80e88c92958c951dc21309f31a64724dbb856/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp
[modify] https://crrev.com/aee80e88c92958c951dc21309f31a64724dbb856/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.h
[modify] https://crrev.com/aee80e88c92958c951dc21309f31a64724dbb856/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.idl

Comment 3 by panicker@chromium.org, Dec 1 2016

Status: Fixed (was: Assigned)

►

Issue 667007 link

Issue metadata

Long Tasks API: Replace culprit domWindow with iframe attrs

Issue description

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Nov 22 2016

Comment 2 Deleted

Comment 3 by panicker@chromium.org, Dec 1 2016

Comment 3 Deleted

Sign in to add a comment