Issue metadata
Sign in to add a comment
|
Regression: The blue magnifiying glass of Tab-To-Search needs to be 1pt to the left |
||||||||||||||||||||||
Issue descriptionVersion: Snapshot 433291 OS: Mac OS 10.11.6 (Tested on Non-Retina) What steps will reproduce the problem? (1) activate Tab-To-Search so that the blue magnifiying glass is to see (2) open a new tab so that the grey magnifiying glass is to see (3) switch between both tabs What is the expected result? What happens instead? The blue magnifiying glass of Tab-To-Search needs to be 1pt to the left. Please use labels and text to provide additional information. This is a Regression after https://codereview.chromium.org/2503713002. A screencast is attached. Adding already M-56 label, because https://codereview.chromium.org/2503713002 will be merged to M-56, too. Thanks and regards Mehmet
,
Nov 22 2016
@spqchan-- Could you please look into this , since it is marked as ReleaseBlock-Beta for M-56. Thanks!
,
Nov 22 2016
,
Nov 23 2016
Thanks for investigation.It would be great if you could have a fix before next Dev Release 11/29, build cut at 3 PM Monday 11/28.
,
Nov 28 2016
M56 beta launch is next week.Your bug is labelled as Release Block beta, please make sure to land the fix by first week of December.
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3a5825e0723184c3f72bffdc916035249318390 commit c3a5825e0723184c3f72bffdc916035249318390 Author: spqchan <spqchan@chromium.org> Date: Tue Nov 29 08:10:53 2016 [Mac] Omnibox text and icon spacing - Moved the BubbleDecoration one pt to the left - Moved the Omnibox text one pt to the left BUG= 666990 , 666977 Review-Url: https://codereview.chromium.org/2520003007 Cr-Commit-Position: refs/heads/master@{#434929} [modify] https://crrev.com/c3a5825e0723184c3f72bffdc916035249318390/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm [modify] https://crrev.com/c3a5825e0723184c3f72bffdc916035249318390/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
,
Nov 29 2016
,
Nov 29 2016
,
Nov 30 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 30 2016
Not sure why nothing is appearing. Anyway, it got merged [Mac] Omnibox text and icon spacing - Moved the BubbleDecoration one pt to the left - Moved the Omnibox text one pt to the left BUG= 666990 , 666977 Review-Url: https://codereview.chromium.org/2520003007 Cr-Commit-Position: refs/heads/master@{#434929} (cherry picked from commit c3a5825e0723184c3f72bffdc916035249318390) Review URL: https://codereview.chromium.org/2543693002 . Cr-Commit-Position: refs/branch-heads/2924@{#196} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
,
Nov 30 2016
,
Nov 30 2016
Thanks for the fix. We will verify in today's canary. If all looks good please merge your change to M56 (branch: 2924) ASAP so that we could take it for next Dev Release.
,
Nov 30 2016
,
Dec 1 2016
Verified the fix on the latest canary(57.0.2938.0) on Mac OS 10.11.6 and compared with build without the fix(57.0.2926.0). This is working as intended. Hence adding the verified label. Thank you!
,
Dec 2 2016
If there is no pending work please remove Merge-Approved-56 label.
,
Dec 2 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by shrike@chromium.org
, Nov 19 2016