New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666990 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: The blue magnifiying glass of Tab-To-Search needs to be 1pt to the left

Project Member Reported by meh...@chromium.org, Nov 19 2016

Issue description

Version: Snapshot 433291
OS: Mac OS 10.11.6 (Tested on Non-Retina)

What steps will reproduce the problem?
(1) activate Tab-To-Search so that the blue magnifiying glass is to see
(2) open a new tab so that the grey magnifiying glass is to see
(3) switch between both tabs

What is the expected result? What happens instead?
The blue magnifiying glass of Tab-To-Search needs to be 1pt to the left.

Please use labels and text to provide additional information.
This is a Regression after https://codereview.chromium.org/2503713002. A screencast is attached.

Adding already M-56 label, because https://codereview.chromium.org/2503713002 will be merged to M-56, too.

Thanks and regards
Mehmet
 
screencast.mov
132 KB Download

Comment 1 by shrike@chromium.org, Nov 19 2016

Labels: ReleaseBlock-Beta

Comment 2 by hdodda@chromium.org, Nov 22 2016

@spqchan-- Could you please look into this , since it is marked as ReleaseBlock-Beta for M-56.

Thanks!
Status: Started (was: Assigned)
Cc: ligim...@chromium.org
Components: UI
Thanks for investigation.It would be great if you could have a fix before next Dev Release 11/29, build cut at 3 PM Monday 11/28.
M56 beta launch is next week.Your bug is labelled as Release Block beta, please make sure to land the fix by first week of December.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3a5825e0723184c3f72bffdc916035249318390

commit c3a5825e0723184c3f72bffdc916035249318390
Author: spqchan <spqchan@chromium.org>
Date: Tue Nov 29 08:10:53 2016

[Mac] Omnibox text and icon spacing

- Moved the BubbleDecoration one pt to the left
- Moved the Omnibox text one pt to the left

BUG= 666990 ,  666977 

Review-Url: https://codereview.chromium.org/2520003007
Cr-Commit-Position: refs/heads/master@{#434929}

[modify] https://crrev.com/c3a5825e0723184c3f72bffdc916035249318390/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
[modify] https://crrev.com/c3a5825e0723184c3f72bffdc916035249318390/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm

Labels: Merge-Request-56

Comment 8 by shrike@chromium.org, Nov 29 2016

Components: -UI UI>Browser>Omnibox

Comment 9 by dimu@chromium.org, Nov 30 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Not sure why nothing is appearing. Anyway, it got merged

[Mac] Omnibox text and icon spacing

- Moved the BubbleDecoration one pt to the left
- Moved the Omnibox text one pt to the left

BUG= 666990 ,  666977 

Review-Url: https://codereview.chromium.org/2520003007
Cr-Commit-Position: refs/heads/master@{#434929}
(cherry picked from commit c3a5825e0723184c3f72bffdc916035249318390)

Review URL: https://codereview.chromium.org/2543693002 .

Cr-Commit-Position: refs/branch-heads/2924@{#196}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Status: Fixed (was: Started)
Thanks for the fix. We will verify in today's canary.

If all looks good please merge your change to M56 (branch: 2924) ASAP so that we could take it for next Dev Release.
Labels: merge-merged-2924

Comment 14 by ajha@chromium.org, Dec 1 2016

Labels: TE-Verified-57.0.2938.0 TE-Verified-M57
Verified the fix on the latest canary(57.0.2938.0) on Mac OS 10.11.6 and compared with build without the fix(57.0.2926.0). This is working as intended.

Hence adding the verified label.

Thank you!
666990.mp4
1.2 MB View Download
If there is no pending work please remove Merge-Approved-56 label.
Labels: -Merge-Approved-56

Sign in to add a comment