New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666987 link

Starred by 10 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Git Revision History is slooooowwwwww

Project Member Reported by benhenry@google.com, Nov 19 2016

Issue description

The Speed Regression sheriffs have been using the Git Revision History feature of CS, but have noticed it's very very slow. Not sure if this is a change from the past.
 
Labels: -Type-Bug Type-Feature
Status: Available (was: Untriaged)
Yeah, the git backend server has to walk the whole revision history of the tree each time, and the Chromium repo is huge.

We should think of some way to make it faster - like building a history index - but this'll be a big project.
 Issue 687371  has been merged into this issue.
Owner: dsansome@chromium.org
Status: Assigned (was: Available)
Dave - is it fair to close this now?
Nope this is still an issue.
Can we rename to something like "Improve speed of Git Revision History by x?"

Comment 6 by emso@chromium.org, Feb 16 2017

Not sure we can change the title of the bug. I don't see an option to do it. We could replace the bug with a new one.

Did you have a specific x in mind?

Comment 7 by emso@chromium.org, Feb 20 2017

 Issue 694224  has been merged into this issue.
Have you considered updating the results without waiting for the scan to finish?
I believe people are mostly interested in recent CLs.
That's how git revision log works, e.g.
https://chromium.googlesource.com/chromium/src/+log/c94b8d06ccb12a284dec1e337a3380ba4cda767f/chrome/browser/ntp_snippets/download_suggestions_provider.h

Comment 9 by emso@chromium.org, Feb 20 2017

That's a good point. We should investigate what it would take to set that up.
This bug also makes the blame layer barely usable. In order to find out more about the CL, one needs to wait for entire history to finish.
wrt comment #8, I think that's true, but from what I remember from the past, people were most concerned about speed when it's related to archaeological research.
Owner: ----
Status: Available (was: Assigned)
Owner: orodley@chromium.org

Comment 14 by no...@chromium.org, May 25 2018

Status: Assigned (was: Available)
(did you mean to set status to Assigned?)

history of
https://cs.chromium.org/chromium/src/build/android/pylib/utils/logdog_helper.py?q=logdog_helper&dr
just took 54s to load


Status: Fixed (was: Assigned)
This is fixed now. See https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/vIZegWuUOPo.

Sign in to add a comment