New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666980 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Incorrect Incognito hover/pressed background for the omnibox icons

Project Member Reported by spqc...@chromium.org, Nov 19 2016

Issue description

The hover/pressed color is incorrect
 
Labels: Merge-Request-56
Merge request for the following:
  https://chromium.googlesource.com/chromium/src.git/+/2edc6f9145d91684f2151462fa20873c29b87b62

commit 2edc6f9145d91684f2151462fa20873c29b87b62
Author: spqchan <spqchan@chromium.org>
Date: Mon Nov 14 19:47:49 2016

[Mac] Hover/Pressed background for the Omnibox decorations

- Added tracking areas for mouse interactive decorations
- Adjusted "popup blocker" bubble so that it has the right spacing for the background

BUG= 588377 ,   662186  

Review-Url: https://codereview.chromium.org/2478673002
Cr-Commit-Position: refs/heads/master@{#431908}

[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/bubble_decoration.h
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.h
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm

Comment 2 by dimu@chromium.org, Nov 19 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 21 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45687a0c12774efa36821bcb7d375db6bc7bc19f

commit 45687a0c12774efa36821bcb7d375db6bc7bc19f
Author: spqchan <spqchan@chromium.org>
Date: Mon Nov 21 18:45:40 2016

[Mac] Fixed the incognito omnibox icon background color

BUG= 588377 ,  666980 

Review-Url: https://codereview.chromium.org/2513083002
Cr-Commit-Position: refs/heads/master@{#433338}
(cherry picked from commit 40b30591e4bb05a0f5fcf4ea85708927ab177c45)

Review URL: https://codereview.chromium.org/2515193003 .

Cr-Commit-Position: refs/branch-heads/2924@{#31}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/45687a0c12774efa36821bcb7d375db6bc7bc19f/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm

Status: Fixed (was: Started)

Sign in to add a comment