Issue metadata
Sign in to add a comment
|
Android selection floating menu not behaving like native one |
||||||||||||||||||||
Issue descriptionVersion: 56.0.2920.0 OS: Android What steps will reproduce the problem? (1) Long press some editable text (2) Select copy What is the expected result? The caret should be positioned where the right selection handle was. What happens instead? There is no caret. There is a similar problem with Cut/Paste. This still works in Chrome Beta (55.0.2883.45).
,
Nov 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ff3e57600d5433dd8d31c5dcdf7d0e26de73f02 commit 4ff3e57600d5433dd8d31c5dcdf7d0e26de73f02 Author: amaralp <amaralp@chromium.org> Date: Sat Nov 19 18:56:00 2016 Calling clearSelection instead of unselect crrev.com/2407303005 introduced a bug by having |onDestroyActionMode| call |mWebContents.unselect()| instead of |clearSelection()|. This CL fixes that. BUG= 666979 Review-Url: https://codereview.chromium.org/2513203002 Cr-Commit-Position: refs/heads/master@{#433427} [modify] https://crrev.com/4ff3e57600d5433dd8d31c5dcdf7d0e26de73f02/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
,
Nov 21 2016
jinsukkim@, could you cherry-pick this? I don't think I have permission.
,
Nov 21 2016
Thanks for handling this. https://codereview.chromium.org/2520803002/
,
Nov 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cce756e78c313d2c121c8d2414fb76eac1d297aa commit cce756e78c313d2c121c8d2414fb76eac1d297aa Author: jinsukkim <jinsukkim@chromium.org> Date: Mon Nov 21 04:27:13 2016 Calling clearSelection instead of unselect crrev.com/2407303005 introduced a bug by having |onDestroyActionMode| call |mWebContents.unselect()| instead of |clearSelection()|. This CL fixes that. BUG= 666979 TBR=aelias@chromium.org Review-Url: https://codereview.chromium.org/2513203002 Cr-Commit-Position: refs/heads/master@{#433427} (cherry picked from commit 4ff3e57600d5433dd8d31c5dcdf7d0e26de73f02) NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2520803002 Cr-Commit-Position: refs/branch-heads/2924@{#18} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/cce756e78c313d2c121c8d2414fb76eac1d297aa/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
,
Nov 21 2016
,
Nov 29 2016
Verified with Chrome Dev '56.0.2924.10' on Galaxy S5. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by aelias@chromium.org
, Nov 19 2016