Issue metadata
Sign in to add a comment
|
Regression: Dropdown text and Omnibox text are no longer vertically aligned |
||||||||||||||||||||||
Issue descriptionVersion: Snapshot 433291 OS: Mac OS 10.11.6 (Tested on Non-Retina) What steps will reproduce the problem? (1) Type something into the Omnibox (2) Compare the Dropdown text with the Omnibox text What is the expected result? What happens instead? The text is no longer vertically aligned. I think the Dropdown text must be 1pt to the right? Please use labels and text to provide additional information. This is a Regression after https://codereview.chromium.org/2503713002. A screenshot is attached. Adding already M-56 label, because https://codereview.chromium.org/2503713002 will be merged to M-56, too. Thanks and regards Mehmet
,
Nov 19 2016
,
Nov 22 2016
@spqchan-- Could you please look into this , since it is marked as ReleaseBlock-Beta for M-56. Thanks!
,
Nov 22 2016
,
Nov 23 2016
In review: https://codereview.chromium.org/2520003007/
,
Nov 23 2016
In review: https://codereview.chromium.org/2520003007/
,
Nov 23 2016
Thanks for fix .We will verify in canary once its committed.Please request a merge to M56 if all looks good. It would be great to have everything set before build cut @3 PM Monday 11/28.
,
Nov 23 2016
Issue 668146 has been merged into this issue.
,
Nov 29 2016
With https://codereview.chromium.org/2520003007/ patched in, it appears that the omnibox text is now 1pt too far to the left.
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3a5825e0723184c3f72bffdc916035249318390 commit c3a5825e0723184c3f72bffdc916035249318390 Author: spqchan <spqchan@chromium.org> Date: Tue Nov 29 08:10:53 2016 [Mac] Omnibox text and icon spacing - Moved the BubbleDecoration one pt to the left - Moved the Omnibox text one pt to the left BUG= 666990 , 666977 Review-Url: https://codereview.chromium.org/2520003007 Cr-Commit-Position: refs/heads/master@{#434929} [modify] https://crrev.com/c3a5825e0723184c3f72bffdc916035249318390/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm [modify] https://crrev.com/c3a5825e0723184c3f72bffdc916035249318390/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
,
Nov 29 2016
Hello spqchan@: We have a new regression now (in latest Snapshot #434983). Please see the attached screenshots. I think, this is because the text in the Omnibox is moved 1pt to the left. Should I file a new report?
,
Nov 29 2016
#11 please file a new report
,
Nov 29 2016
From #11 it seems like the fix you landed in #10 caused this new issue. Does it make more sense to address it here than to file a new bug?
,
Nov 29 2016
,
Nov 29 2016
Filed issue 669568 re#11-13. Please feel free to close it, if you want to fix it with this report.
,
Nov 30 2016
The CL got merged. I'm going to fix that new issue on the new bug. I labelled that issue as ReleaseBlock-Stable [Mac] Omnibox text and icon spacing - Moved the BubbleDecoration one pt to the left - Moved the Omnibox text one pt to the left BUG= 666990 , 666977 Review-Url: https://codereview.chromium.org/2520003007 Cr-Commit-Position: refs/heads/master@{#434929} (cherry picked from commit c3a5825e0723184c3f72bffdc916035249318390) Review URL: https://codereview.chromium.org/2543693002 . Cr-Commit-Position: refs/branch-heads/2924@{#196} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
,
Nov 30 2016
,
Nov 30 2016
[Auto-generated comment by a script] We noticed that this issue is targeted for M-56; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-56 label, otherwise remove Merge-TBD label. Thanks.
,
Dec 2 2016
Looks like the CL is merged in M56 Branch.If there is no pending work please remove merge-TBD add merge-merged-2924 label.
,
Dec 2 2016
,
Dec 16 2016
This bug requires manual review: No test file found in commits. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 16 2016
This bug requires manual review: No test file found in commits. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 16 2016
[Automated comment] removing mislabelled Merge-Review-56, Hotlist-Merge-Review |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by meh...@chromium.org
, Nov 19 2016