New issue
Advanced search Search tips

Issue 666975 link

Starred by 1 user
Status: Archived
Owner:
jrumm...@chromium.org
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

keystatuschange event with status = 'released' fails.

Project Member Reported by jrumm...@chromium.org, Nov 19 2016 
After calling MediaKeySession.remove(), the CDM is expected to send a keystatuschange event with all keys tagged as 'released'. However, when that happens:

[1:1:1118/160357:FATAL:ppapi_messages.h(98)] Check failed: (static_cast<int>(value) >= static_cast<int>(0) && static_cast<int>(value) <= static_cast<int>(PP_CDMKEYSTATUS_STATUSPENDING)). 

Range checked for PP_CdmKeyStatus is incorrect (not allowing PP_CDMKEYSTATUS_RELEASED).
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c24785e7ff8bf6ce47d903b598d813e1bbd17fab

commit c24785e7ff8bf6ce47d903b598d813e1bbd17fab
Author: jrummell <jrummell@chromium.org>
Date: Tue Nov 22 02:42:34 2016

Fix range checking for PP_CdmKeyStatus

The specified maximum value doesn't allow PP_CDMKEYSTATUS_RELEASED,
so update it.

BUG= 666975 
TEST=Tested with W3C EME tests

Review-Url: https://codereview.chromium.org/2514123004
Cr-Commit-Position: refs/heads/master@{#433754}

[modify] https://crrev.com/c24785e7ff8bf6ce47d903b598d813e1bbd17fab/ppapi/api/private/pp_content_decryptor.idl
[modify] https://crrev.com/c24785e7ff8bf6ce47d903b598d813e1bbd17fab/ppapi/c/private/pp_content_decryptor.h
[modify] https://crrev.com/c24785e7ff8bf6ce47d903b598d813e1bbd17fab/ppapi/proxy/ppapi_messages.h

Comment 2 by jrumm...@chromium.org, Nov 22 2016

Status: Fixed (was: Started)

Comment 3 by jrumm...@chromium.org, Nov 30 2016

Labels: Merge-Request-56
As this affects the W3C EME tests, requesting permission to merge this into M56.

Comment 4 by dimu@chromium.org, Nov 30 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 30 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a40ddfb7300ac34f01e3d0bf41ae7d6dea222b99

commit a40ddfb7300ac34f01e3d0bf41ae7d6dea222b99
Author: John Rummell <jrummell@chromium.org>
Date: Wed Nov 30 23:13:43 2016

Merge "Fix range checking for PP_CdmKeyStatus"

The specified maximum value doesn't allow PP_CDMKEYSTATUS_RELEASED,
so update it.

BUG= 666975 
TEST=Tested with W3C EME tests

Review-Url: https://codereview.chromium.org/2514123004
Cr-Commit-Position: refs/heads/master@{#433754}
(cherry picked from commit c24785e7ff8bf6ce47d903b598d813e1bbd17fab)

Review URL: https://codereview.chromium.org/2541193002 .

Cr-Commit-Position: refs/branch-heads/2924@{#224}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/a40ddfb7300ac34f01e3d0bf41ae7d6dea222b99/ppapi/api/private/pp_content_decryptor.idl
[modify] https://crrev.com/a40ddfb7300ac34f01e3d0bf41ae7d6dea222b99/ppapi/c/private/pp_content_decryptor.h
[modify] https://crrev.com/a40ddfb7300ac34f01e3d0bf41ae7d6dea222b99/ppapi/proxy/ppapi_messages.h

Comment 6 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 7 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 8 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
►

Sign in to add a comment