We should not use SDK's Request as it's primary way to communicate data about rows. By abstracting the dependencies away will make it easier to allow multiple requests to be grouped per row.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c57a4062b232e2aa7a538d637b5f2000107e6c6d commit c57a4062b232e2aa7a538d637b5f2000107e6c6d Author: allada <allada@chromium.org> Date: Tue Nov 22 02:44:46 2016 [Devtools] Moved NetworkWaterfallColumn to use NetworkLogEntry This patch is in prep to allow NetworkLogView/Columns to communicate in a multi-request manner for network groupping for the NetworkLogView. R=dgozman BUG= 666971 Review-Url: https://codereview.chromium.org/2514123002 Cr-Commit-Position: refs/heads/master@{#433755} [modify] https://crrev.com/c57a4062b232e2aa7a538d637b5f2000107e6c6d/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js [modify] https://crrev.com/c57a4062b232e2aa7a538d637b5f2000107e6c6d/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js [modify] https://crrev.com/c57a4062b232e2aa7a538d637b5f2000107e6c6d/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js [modify] https://crrev.com/c57a4062b232e2aa7a538d637b5f2000107e6c6d/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js [modify] https://crrev.com/c57a4062b232e2aa7a538d637b5f2000107e6c6d/third_party/WebKit/Source/devtools/front_end/ui_lazy/ViewportDataGrid.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a92e8ab145d34cea6dfc94f9084e78e2724512a commit 2a92e8ab145d34cea6dfc94f9084e78e2724512a Author: allada <allada@chromium.org> Date: Fri Dec 02 02:39:52 2016 [Devtools] Rename logEntries to node in network This patch is in prepopration for groupping in network panel. Before we introduced logEntries as an interface, but this is proving to difficult to work with and complicating the code. We decided to move to use NetworkDataGridNode instead of an interface. This patch is just a rename. R=dgozman BUG= 666971 Review-Url: https://codereview.chromium.org/2548663002 Cr-Commit-Position: refs/heads/master@{#435831} [modify] https://crrev.com/2a92e8ab145d34cea6dfc94f9084e78e2724512a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js [modify] https://crrev.com/2a92e8ab145d34cea6dfc94f9084e78e2724512a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js [modify] https://crrev.com/2a92e8ab145d34cea6dfc94f9084e78e2724512a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js [modify] https://crrev.com/2a92e8ab145d34cea6dfc94f9084e78e2724512a/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3233bf976db8eee4b868a461534273a6d268b995 commit 3233bf976db8eee4b868a461534273a6d268b995 Author: allada <allada@chromium.org> Date: Wed Dec 21 03:04:45 2016 [Devtools] Moved hover tracking and initiator tracking into NetworkDataGridNode This patch moves some of thre tracking info for waterfall and network datagrid into NetworkDataGridNode. This is in an effort to remove as much dependency on NetworkLogViewColumns as possible form waterfall. R=dgozman BUG= 666971 Review-Url: https://codereview.chromium.org/2540893002 Cr-Commit-Position: refs/heads/master@{#439991} [modify] https://crrev.com/3233bf976db8eee4b868a461534273a6d268b995/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js [modify] https://crrev.com/3233bf976db8eee4b868a461534273a6d268b995/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js [modify] https://crrev.com/3233bf976db8eee4b868a461534273a6d268b995/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js [modify] https://crrev.com/3233bf976db8eee4b868a461534273a6d268b995/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
Comment 1 by bugdroid1@chromium.org
, Nov 22 2016