New issue
Advanced search Search tips

Issue 666937 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Add a check that build dependencies are installed before trying building Chrome

Project Member Reported by thomasanderson@chromium.org, Nov 18 2016

Issue description

'build/install-build-deps.sh --quick-check' should be run during 'gclient runhooks' to ensure all of the packages required to build Chrome are available in the build environment.

The motivation for this addition was a CQ outage caused by a CL that added new font dependencies to the build, but the fonts weren't installed on most builders.  The subset of trybots used to land that CL happened to have the necessary fonts, but subsequently caused extreme flakiness in the CQ after landing.  It was difficult to track down the offending CL since tests were failing that gave nondescript errors.  With this change, it should be much easier to track down this type of failure in the future.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73b3a441a128d14c81bed7afc981d35f0f401f1d

commit 73b3a441a128d14c81bed7afc981d35f0f401f1d
Author: thomasanderson <thomasanderson@google.com>
Date: Fri Nov 18 23:16:07 2016

Fix install-build-deps.sh --quick-check

The algorithm we were using to parse the output of dpkg-query was out of date because the format changed.

This CL tries to make as little assumptions as possible about the output of dpkg-query, using the return code to determine failure instead of the output.  However, we still rely on the last word of an error message being a package name, although this is only used to display which packages are missing.

BUG=666937
R=mmoss@chromium.org,dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2519523002
Cr-Commit-Position: refs/heads/master@{#433327}

[modify] https://crrev.com/73b3a441a128d14c81bed7afc981d35f0f401f1d/build/install-build-deps.sh

Status: Started (was: Star)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8942c0a68a986313e2927de584a644c8d21b230

commit e8942c0a68a986313e2927de584a644c8d21b230
Author: thomasanderson <thomasanderson@google.com>
Date: Mon Nov 21 19:27:56 2016

Add check_build_deps step to gclient runhooks

This CL adds a build hook to ensure that any necessary build
dependencies are installed before proceeding with the
build.  A failure would indicate install_build_deps.sh
needs to be rerun.

BUG=666937
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2505413003
Cr-Commit-Position: refs/heads/master@{#433603}

[modify] https://crrev.com/e8942c0a68a986313e2927de584a644c8d21b230/DEPS
[add] https://crrev.com/e8942c0a68a986313e2927de584a644c8d21b230/build/check-build-deps.py
[modify] https://crrev.com/e8942c0a68a986313e2927de584a644c8d21b230/build/install-build-deps.sh

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ae919e5336c1d4a3a3455f82f85cdd06162d2f1

commit 2ae919e5336c1d4a3a3455f82f85cdd06162d2f1
Author: anthonyvd <anthonyvd@chromium.org>
Date: Mon Nov 21 19:47:12 2016

Revert of Add check_build_deps step to gclient runhooks (patchset #2 id:20001 of https://codereview.chromium.org/2505413003/ )

Reason for revert:
This change breaks the following bot: http://build.chromium.org/p/chromium.linux/builders/Cast%20Android%20%28dbg%29/builds/56654

This appears to be the intended behavior of the change, although the bots should probably not break when it lands to avoid a closed tree.

Original issue's description:
> Add check_build_deps step to gclient runhooks
>
> This CL adds a build hook to ensure that any necessary build
> dependencies are installed before proceeding with the
> build.  A failure would indicate install_build_deps.sh
> needs to be rerun.
>
> BUG=666937
> R=dpranke@chromium.org
>
> Committed: https://crrev.com/e8942c0a68a986313e2927de584a644c8d21b230
> Cr-Commit-Position: refs/heads/master@{#433603}

TBR=dpranke@chromium.org,thomasanderson@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=666937

Review-Url: https://codereview.chromium.org/2521733002
Cr-Commit-Position: refs/heads/master@{#433611}

[modify] https://crrev.com/2ae919e5336c1d4a3a3455f82f85cdd06162d2f1/DEPS
[delete] https://crrev.com/6e6c35e40f934ca1dc531b87f5b2f375a30c8e44/build/check-build-deps.py
[modify] https://crrev.com/2ae919e5336c1d4a3a3455f82f85cdd06162d2f1/build/install-build-deps.sh

An infra bug is opened at Issue 667440 to request updating that bot's dependencies.
You started fixing this bug over two years ago. Are you still working on it? You can update the status to "archived", "wontfix", or "closed". You can remove yourself as owner and change status to "untriaged", but if this is still a real bug, please do not sit on it.
Status: Assigned (was: Started)

Sign in to add a comment