New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 666912 link

Starred by 2 users
Status: Fixed
Owner:
rbyers@chromium.org
Closed: Nov 2016
Cc:
rickyz@chromium.org
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 501069



Sign in to add a comment

pid in histogram JSON is always 1 on linux

Project Member Reported by rbyers@chromium.org, Nov 18 2016 
StatsCollectionController::GetHistogram returns a histogram in JSON format including a 'pid' entry.

Due to issue 501069 this 'pid' value is always 1.

This prevents the SubtractHistogram protection in (catapult histogram_util.py) from kicking in.

The code should probably be changed from GetCurrentProcId() to GetUniqueIdForProcess().
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a25fa4d84368bc2316a3291e3acd4b8f493e724

commit 6a25fa4d84368bc2316a3291e3acd4b8f493e724
Author: rbyers <rbyers@chromium.org>
Date: Fri Nov 25 16:24:18 2016

Fix histogram pid value

Use GetUniqueIdForProcess instead of GetCurrentProcId which is always
1 on Linux.

BUG= 666912 

Review-Url: https://codereview.chromium.org/2516433005
Cr-Commit-Position: refs/heads/master@{#434522}

[modify] https://crrev.com/6a25fa4d84368bc2316a3291e3acd4b8f493e724/base/metrics/histogram_base.cc

Comment 2 by rbyers@chromium.org, Nov 25 2016

Cc: rickyz@chromium.org
Status: Fixed (was: Started)
►

Sign in to add a comment