New issue
Advanced search Search tips

Issue 666884 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 657117



Sign in to add a comment

WPT Export: Don't export commits with NOEXPORT=true

Project Member Reported by jeffcarp@chromium.org, Nov 18 2016

Issue description

Following up from this CL:
https://codereview.chromium.org/2512563002

The export script should not export commits with the footer NOEXPORT=true
 
Status: Started (was: Assigned)
Blockedon: 657117
Labels: -WPTExport
Blockedon: -657117
Blocking: 657117
This functionality is included in this CL:
https://codereview.chromium.org/2518313003
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06bc68e15d0b41c94ddc85a6b5713da14561823f

commit 06bc68e15d0b41c94ddc85a6b5713da14561823f
Author: jeffcarp <jeffcarp@chromium.org>
Date: Tue Nov 29 20:34:00 2016

Refactor WPT Export to ensure only one PR in flight at a time

This CL:
- Moves out all export logic into its own class, TestExporter
- sync_wpt.py is still a shell that sets up all the classes and calls TestExporter
- Changes the 'exportable' logic to honor NOEXPORT=true
- Renames GitHub to WPTGitHub
- Adds a bunch more unit tests

This CL has not yet been tested on a real export. I hope to do a real export soon and improve/fix the code in the process.

BUG= 666809 
BUG= 666884 

Review-Url: https://codereview.chromium.org/2518313003
Cr-Commit-Position: refs/heads/master@{#435071}

[modify] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py
[modify] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_wpt.py
[modify] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_wpt_unittest.py
[delete] https://crrev.com/cb7a3e4d33a7059b2734ba7708db0116c241cb43/third_party/WebKit/Tools/Scripts/webkitpy/w3c/github.py
[delete] https://crrev.com/cb7a3e4d33a7059b2734ba7708db0116c241cb43/third_party/WebKit/Tools/Scripts/webkitpy/w3c/github_unittest.py
[modify] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
[modify] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py
[modify] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/sync_wpt.py
[add] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py
[add] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py
[add] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py
[add] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github_mock.py
[add] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github_unittest.py

Status: Fixed (was: Started)

Sign in to add a comment