servo: cros_ec_softrec_power: not allowing enough time for recovery boots to be processed. |
|||
Issue descriptionI noticed that the the cros_ec_softrec driver may not allow sufficient time for devices to process a recovery boot. I had fixed this for the cros_ec_pd power state driver, but I think a similar fix needs to be in place for the other driver. This will allow slower devices to configure their recovery boot. It's usually not a problem since most boards are quick.
,
Nov 21 2016
CL with the fix here: https://chromium-review.googlesource.com/c/412975/
,
Nov 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/e6856cebadbbbfb494fd6b806ccb68f419252ac1 commit e6856cebadbbbfb494fd6b806ccb68f419252ac1 Author: Aseda Aboagye <aaboagye@google.com> Date: Mon Nov 21 20:51:03 2016 cros_ec_softrec: Allow time to reach rec screen. It takes some time to reach the recovery screen for devices. Most of the time it's fairly quick, where other boards make take a longer time to do so. The power state driver would immediately yield after issuing "power_state:rec" but it was not waiting until the device had actually booted up into recovery. This commit adds a parameter called "boot_to_rec_screen_delay" which can be used in the board's XML file. It will default to 5 seconds, but any board can override that if they require a longer delay to reach the recovery screen. BUG= chromium:666872 BRANCH=None TEST=run platform_ServoPowerStateControllerUSBUnplugged for kevin on servo v2 and verify that it passes. TEST=set boot_to_rec_screen_delay to 10s for reef and run platform_ServoPowerStateControllerUSBPluggedin for reef on servo v2 and verify that it passes. Change-Id: I757906271a373ea7c570f5aa84c96b51c341a732 Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/412975 Commit-Ready: Nicolas Boichat <drinkcat@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Shelley Chen <shchen@chromium.org> [modify] https://crrev.com/e6856cebadbbbfb494fd6b806ccb68f419252ac1/servo/drv/cros_ec_softrec_power.py
,
Nov 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/9f865d48ae82dabfe060ee63aee806a9da0fd215 commit 9f865d48ae82dabfe060ee63aee806a9da0fd215 Author: Aseda Aboagye <aaboagye@google.com> Date: Mon Nov 21 21:45:18 2016 servo: reef: set boot_to_rec_screen_delay to 10s. Reef currently takes awhile to boot to the recovery screen. This commit adds this parameter for the power state driver so that it will delay the appropriate length of time before yielding control. BUG= chromium:666872 BRANCH=None TEST=run platform_ServoPowerStateControllerUSBPluggedin for reef and verify that it passes. Change-Id: I3346eb08c5e6edc61ae1f7bc8e76aba43f346a18 Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/413077 Commit-Ready: Nicolas Boichat <drinkcat@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Shelley Chen <shchen@chromium.org> [modify] https://crrev.com/9f865d48ae82dabfe060ee63aee806a9da0fd215/servo/data/servo_reef_overlay.xml
,
Nov 28 2016
Verified in CL. |
|||
►
Sign in to add a comment |
|||
Comment 1 by aaboagye@chromium.org
, Nov 21 2016