use of chrome://settings in arc_util.py undesirable |
||||||
Issue descriptionenable_arc_setting in arc_util.py opens a tab with chrome://settings, and scrapes various dom elements to enable arc. https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/client/common_lib/cros/arc_util.py?l=137-179 This will definitely break with md-settings, and in general is fragile to renaming. We should use a well-defined autotestPrivate API to achieve this instead. We already use autotestPrivate for visible notifications for ARC++ here: https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/client/common_lib/cros/chrome.py?type=cs&l=252 enable_arc_settings shouldn't be raising error.TestFail, and should be catching more specific exceptions, not Exception.
,
Nov 21 2016
,
Nov 21 2016
,
Nov 21 2016
I don't think so. 666146 is a specific issue with how tabs are handled. This is more of a general design issue with how we detect whether arc is enabled and/or managed. I'm not too familiar with autotestPrivate (and couldn't find any documentation) but it looks like we could probably use that to detect the current opt-in/managed status.
,
Nov 21 2016
,
Nov 21 2016
Yeah, not a dupe. Issue 666146 makes the current approach leave things in a better state, but that approach shouldn't be used in the first place. :-)
,
May 23 2017
Hmmm this bug sounds wrong, this is an autotest to excercise if an UI feature is functional and breaking this if you change the UI is expected.
,
May 23 2017
Autotest isn't the right tool for exercising the Chrome UI -- that's what Chrome tests are for. Use autotest for integration testing. Autotests that depend on the DOM are extremely fragile and hard to maintain. Nobody's going to know to update them when they make a Chrome change (and the test would need to support multiple versions of the Chrome code simultaneously).
,
May 23 2017
+1 to what derat@ said, but I believe this was addressed in issue 694081 , specifically here: https://chromium-review.googlesource.com/c/470707/8/client/common_lib/cros/arc_util.py |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by achuith@chromium.org
, Nov 18 2016