New issue
Advanced search Search tips

Issue 666869 link

Starred by 1 user
Status: Fixed
Owner:
jrumm...@chromium.org
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

EME WPT idlharness.html failure: MediaKeyMessageEvent interface object length

Project Member Reported by ddorwin@chromium.org, Nov 18 2016 
The "MediaKeyMessageEvent interface object length" test at http://www.w3c-test.org/encrypted-media/idlharness.html fails with the following error:

> assert_equals: wrong value for MediaKeyMessageEvent.length expected 2 but got 1

Note: The "MediaEncryptedEvent interface object length" test passes. These are both custom event types with two parameters.

I don't remember seeing this when I originally looked at the IDL test failures, but I could be wrong. It fails in both M54 and M56. It might have been caused by https://github.com/w3c/web-platform-tests/commit/fe565a9ffd883246b956c75750039a8b04994cc5#diff-57f92c071457a3c51e03bc8bf689457d

I see that Blink's MediaKeyMessageEvent.idl still has "optional" for eventInitDict. Maybe fixing that will fix this test.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23ca36ab9e996dfad12a6bd21346208c56f918d0

commit 23ca36ab9e996dfad12a6bd21346208c56f918d0
Author: jrummell <jrummell@chromium.org>
Date: Fri Nov 18 23:03:36 2016

EME: Update MediaKeyMessageEvent to match spec

MediaKeyMessageEventInit is now required for the constructor.

BUG= 666869 
TEST=W3C EME test mentioned in the bug no longer fails.

Review-Url: https://codereview.chromium.org/2514933002
Cr-Commit-Position: refs/heads/master@{#433323}

[modify] https://crrev.com/23ca36ab9e996dfad12a6bd21346208c56f918d0/third_party/WebKit/Source/modules/encryptedmedia/MediaKeyMessageEvent.idl

Comment 2 by ddorwin@chromium.org, Nov 18 2016

Status: Verified (was: Assigned)

Comment 3 by ddorwin@chromium.org, Nov 21 2016

Labels: Merge-Request-56
Status: Assigned (was: Verified)
This is a trivial IDL change to match the spec and pass the IDL spec test. I'd like M56 to be "complete" in this area.

Comment 4 by dimu@chromium.org, Nov 21 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 22 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab838c4a9c12c1e003607c9fdeaea4333cdcbec4

commit ab838c4a9c12c1e003607c9fdeaea4333cdcbec4
Author: John Rummell <jrummell@chromium.org>
Date: Tue Nov 22 01:47:37 2016

Merge "EME: Update MediaKeyMessageEvent to match spec"

MediaKeyMessageEventInit is now required for the constructor.

BUG= 666869 
TEST=W3C EME test mentioned in the bug no longer fails.

Review-Url: https://codereview.chromium.org/2514933002
Cr-Commit-Position: refs/heads/master@{#433323}
(cherry picked from commit 23ca36ab9e996dfad12a6bd21346208c56f918d0)

Review URL: https://codereview.chromium.org/2518213002 .

Cr-Commit-Position: refs/branch-heads/2924@{#52}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/ab838c4a9c12c1e003607c9fdeaea4333cdcbec4/third_party/WebKit/Source/modules/encryptedmedia/MediaKeyMessageEvent.idl

Comment 6 by jrumm...@chromium.org, Nov 22 2016

Status: Fixed (was: Assigned)

Comment 7 by ddorwin@chromium.org, Nov 22 2016

Labels: M-57 M-56
Fixed in M56 and later.
►

Sign in to add a comment