Swarming task executes successfully locally but fails remotely. |
||
Issue descriptionThe following task fails https://chromium-swarm.appspot.com/task?id=3291b3ba8fa6d610&refresh=10&show_raw=1 but when I execute python tools\swarming_client\swarming.py reproduce -S https://chromium-swarm.appspot.com 3291b3ba8fa6d610 it succeeds. The problem seems to be that it can't find ..\..\third_party\gtest-parallel\gtest-parallel, but it appears in the isolated inputs and also in the files downloaded when executed locally. It also fails when triggered from the buildbots.
,
Nov 18 2016
OK, I'll do that instead, thanks :). And this is just a proof of concept right now.
That comes from test_env.py I assume.
The command I'm running is
"../../testing/test_env.py",
"python",
"../../third_party/gtest-parallel/gtest-parallel-wrapper",
".\\audio_decoder_unittests.exe",
"--",
"--asan=0",
"--msan=0",
"--tsan=0"
,
Nov 18 2016
I'm not sure why the output looks like that. I'd think it'd be printed first and then the output from gtest-parallel-wrapper
,
Nov 18 2016
Ok so at least I found one bug in the test framework. CL sent for this. "python" is likely getting in the way, try removing it. But that would require you to rename the wrapper to end with .py and make it executable on POSIX. Do both.
,
Nov 18 2016
How do I make it executable on POSIX?
,
Nov 18 2016
git mv gtest-parallel-wrapper gtest-parallel-wrapper.py chmod +x gtest-parallel-wrapper.py git commit -a -m "+x"
,
Nov 18 2016
Huh, I didn't know permissions were stored too. Good to know :) I'll do it in about half an hour. I don't see how it would be getting in the way, but it's worth a try.
,
Nov 18 2016
It fixed it, thanks.
,
Nov 18 2016
It'd be nice to know why it didn't fail locally, tho.
,
Nov 18 2016
Hypothesis: you may have python.exe in your PATH. The bots don't.
,
Nov 18 2016
But you can see that the command executed by test_env.py is e:\b\depot_tools\python276_bin\python.exe ../../third_party/gtest-parallel/gtest-parallel-wrapper .\audio_decoder_unittests.exe -- And the command executed by gtest-parallel-wrapper is e:\b\depot_tools\python276_bin\python.exe ..\..\third_party\gtest-parallel\gtest-parallel --shard_count 1 --shard_index 0 .\audio_decoder_unittests.exe -- So having python shouldn't be necessary, since you're executing the command via the absolute path. And it looks like (at least some of) the bots do have python in PATH. (search for 'PATH': 'e:\\b\\depot_tools\\python276_bin;) https://chromium-swarm.appspot.com/task?id=3292555964652410&refresh=10&show_raw=1
,
Nov 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f00125f82a0e0ce948644ff239941e6f727984bf commit f00125f82a0e0ce948644ff239941e6f727984bf Author: maruel <maruel@chromium.org> Date: Sat Nov 19 00:01:14 2016 Flush stdout before shelling out. Otherwise the output can be intermingled. R=dpranke@chromium.org BUG= 666867 Review-Url: https://codereview.chromium.org/2515643003 Cr-Commit-Position: refs/heads/master@{#433340} [modify] https://crrev.com/f00125f82a0e0ce948644ff239941e6f727984bf/testing/test_env.py |
||
►
Sign in to add a comment |
||
Comment 1 by mar...@chromium.org
, Nov 18 2016Owner: ehmaldonado@chromium.org