We need to add TargetHandler here: https://cs.chromium.org/chromium/src/content/browser/devtools/browser_devtools_agent_host.cc?type=cs&sq=package:chromium&l=46 But we can only expose it behind a command line flag or in headless mode.
Downstream issue: https://github.com/GoogleChrome/lighthouse/issues/970#issuecomment-261620008 Pavel, you think we can get into this next so we can smooth out our headless integration?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e1171c8c293d8bcc8cf0eeb53583e7aaaff8c34 commit 5e1171c8c293d8bcc8cf0eeb53583e7aaaff8c34 Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Fri Aug 04 23:24:48 2017 Roll src/third_party/catapult/ 357e1deef..0fb50e3f8 (5 commits) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/357e1deefca7..0fb50e3f84ef $ git log 357e1deef..0fb50e3f8 --date=short --no-merges --format='%ad %ae %s' 2017-08-04 etienneb Add support for fetching M61 clang builds R=erikchen@chromium.org BUG= chromium:752336 2017-08-04 pfeldman Take non-default browser target location into account when attaching to it. 2017-08-04 konkers Add fuchsia tracing importer. 2017-08-04 ashleymarie Add FormatDisabled for json_3_output_formatter 2017-08-04 benjhayden Display histogram and sample diagnostics in a tab-view in histogram-span. Created with: roll-dep src/third_party/catapult BUG= 666865 , 751346 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: If43a288c7c2d36402d4e3183345de7f6065803a8 Reviewed-on: https://chromium-review.googlesource.com/602681 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#492169} [modify] https://crrev.com/5e1171c8c293d8bcc8cf0eeb53583e7aaaff8c34/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77da4d5dc8d3e2bfb7bc090d5d960fa5500c4aa7 commit 77da4d5dc8d3e2bfb7bc090d5d960fa5500c4aa7 Author: Pavel Feldman <pfeldman@chromium.org> Date: Sat Aug 05 11:59:24 2017 DevTools: enable target domain handler on the browser target, make browser target non-discoverable. Bug: 666865 Change-Id: I9c4b431db1a4b2ecf34d817d13c3a5c3010790ed TBR: change in the API NOPRESUBMIT: true Reviewed-on: https://chromium-review.googlesource.com/596719 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#492236} [modify] https://crrev.com/77da4d5dc8d3e2bfb7bc090d5d960fa5500c4aa7/android_webview/browser/aw_devtools_manager_delegate.cc [modify] https://crrev.com/77da4d5dc8d3e2bfb7bc090d5d960fa5500c4aa7/android_webview/browser/aw_devtools_manager_delegate.h [modify] https://crrev.com/77da4d5dc8d3e2bfb7bc090d5d960fa5500c4aa7/chrome/browser/android/devtools_manager_delegate_android.cc [modify] https://crrev.com/77da4d5dc8d3e2bfb7bc090d5d960fa5500c4aa7/chrome/browser/android/devtools_manager_delegate_android.h [modify] https://crrev.com/77da4d5dc8d3e2bfb7bc090d5d960fa5500c4aa7/chrome/browser/devtools/device/devtools_device_discovery.cc [modify] https://crrev.com/77da4d5dc8d3e2bfb7bc090d5d960fa5500c4aa7/chrome/browser/devtools/device/devtools_device_discovery.h [modify] https://crrev.com/77da4d5dc8d3e2bfb7bc090d5d960fa5500c4aa7/chrome/browser/devtools/device/port_forwarding_controller.cc [modify] https://crrev.com/77da4d5dc8d3e2bfb7bc090d5d960fa5500c4aa7/content/browser/devtools/browser_devtools_agent_host.cc [modify] https://crrev.com/77da4d5dc8d3e2bfb7bc090d5d960fa5500c4aa7/content/browser/devtools/devtools_http_handler.cc [modify] https://crrev.com/77da4d5dc8d3e2bfb7bc090d5d960fa5500c4aa7/content/browser/devtools/devtools_http_handler.h [modify] https://crrev.com/77da4d5dc8d3e2bfb7bc090d5d960fa5500c4aa7/content/browser/devtools/devtools_http_handler_unittest.cc [modify] https://crrev.com/77da4d5dc8d3e2bfb7bc090d5d960fa5500c4aa7/content/public/browser/devtools_manager_delegate.cc [modify] https://crrev.com/77da4d5dc8d3e2bfb7bc090d5d960fa5500c4aa7/content/public/browser/devtools_manager_delegate.h
Comment 1 by paulir...@chromium.org
, Feb 16 2017