New issue
Advanced search Search tips

Issue 666862 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

UMA metrics for blobs are wrong

Project Member Reported by dmu...@chromium.org, Nov 18 2016

Issue description

I messed it up when refactoring.
 
Labels: -Pri-3 M-56 ReleaseBlock-Beta Pri-1

Comment 2 by dmu...@chromium.org, Nov 22 2016

Labels: Merge-Request-56
Not sure why it wasn't reported here, but this has been committed here:
https://codereview.chromium.org/2514513004/

Comment 3 by dimu@chromium.org, Nov 23 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 23 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa7af7cdfd43527f2e0d1e9059807dacb377be26

commit fa7af7cdfd43527f2e0d1e9059807dacb377be26
Author: Daniel Murphy <dmurph@chromium.org>
Date: Wed Nov 23 18:29:00 2016

[BlobStorage] Fix UMA reporting.

R=jsbell@chromium.org
BUG= 666862 

Review-Url: https://codereview.chromium.org/2514513004
Cr-Commit-Position: refs/heads/master@{#433760}
(cherry picked from commit 1e85b53656cc7053706890de27b3061a1390a153)

Review URL: https://codereview.chromium.org/2521723008 .

Cr-Commit-Position: refs/branch-heads/2924@{#79}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/fa7af7cdfd43527f2e0d1e9059807dacb377be26/storage/browser/blob/blob_storage_context.cc
[modify] https://crrev.com/fa7af7cdfd43527f2e0d1e9059807dacb377be26/tools/metrics/histograms/histograms.xml

Thanks for the fix. Please tag it as fixed once all looks good.

Comment 6 by dmu...@chromium.org, Nov 23 2016

Status: Fixed (was: Assigned)

Sign in to add a comment