New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666828 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Xoogler
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

tracing_perftests failing on all Android bots

Project Member Reported by charliea@chromium.org, Nov 18 2016

Issue description

Link to failing step log: http://bit.ly/2g5Uzhh

Excerpt from log:

Traceback (most recent call last):
  File "/b/rr/tmpY2qgkd/rw/checkout/scripts/slave/runtest.py", line 1776, in <module>
    sys.exit(main())
  File "/b/rr/tmpY2qgkd/rw/checkout/scripts/slave/runtest.py", line 1747, in main
    result = _MainLinux(options, args, extra_env)
  File "/b/rr/tmpY2qgkd/rw/checkout/scripts/slave/runtest.py", line 1159, in _MainLinux
    raise chromium_utils.PathNotFound(msg)
common.chromium_utils.PathNotFound: Unable to find /b/rr/tmpY2qgkd/w/src/out/Release/bin/run_tracing_perftests
Command ['/usr/bin/python', u'/b/rr/tmpY2qgkd/rw/checkout/scripts/tools/runit.py', '--show-path', '/usr/bin/python', u'/b/rr/tmpY2qgkd/rw/checkout/scripts/slave/runtest.py', '--target', 'Release', '--xvfb', '--builder-name', u'Android Nexus5 Perf (2)', '--slave-name', u'build14-b1', '--build-number', '4343', '--build-properties', '{"results-url": "https://chromeperf.appspot.com", "buildername": "Android Nexus5 Perf (2)", "perf-id": "android-nexus5", "mastername": "chromium.perf", "buildnumber": 4343, "slavename": "build14-b1", "target_platform": "android"}', '--target', 'Release', '--annotate', 'graphing', '--perf-id', u'android-nexus5', '--perf-dashboard-id', u'tracing_perftests', '--results-url', u'https://chromeperf.appspot.com', '--slave-name', u'build14-b1', '--builder-name', u'Android Nexus5 Perf (2)', '--build-number', '4343', '--log-processor-output-file', '/tmp/tmp3uFmPz', '--test-type', u'tracing_perftests', '--no-xvfb', '--run-python-script', u'/b/rr/tmpY2qgkd/w/src/out/Release/bin/run_tracing_perftests', '--verbose', u'--adb-path', u'src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb'] returned exit code 1
Traceback (most recent call last):
  File "/b/rr/tmpY2qgkd/w/src/testing/scripts/gtest_perf_test.py", line 81, in <module>
    sys.exit(common.run_script(sys.argv[1:], funcs))
  File "/b/rr/tmpY2qgkd/w/src/testing/scripts/common.py", line 63, in run_script
    return args.func(args)
  File "/b/rr/tmpY2qgkd/w/src/testing/scripts/gtest_perf_test.py", line 59, in main_run
    results = json.load(f)
  File "/usr/lib/python2.7/json/__init__.py", line 290, in load
    **kw)
  File "/usr/lib/python2.7/json/__init__.py", line 338, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python2.7/json/decoder.py", line 366, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python2.7/json/decoder.py", line 384, in raw_decode
    raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded
step returned non-zero exit code: 1
@@@STEP_LOG_LINE@json.output (invalid)@null@@@
@@@STEP_LINK@logdog-->json.output (invalid)@https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_Nexus5_Perf__2_%2F4343%2F%2B%2Frecipes%2Fsteps%2Ftracing_perftests%2F0%2Flogs%2Fjson.output__invalid_%2F0@@@
@@@STEP_LOG_END@json.output (invalid)@@@
@@@STEP_FAILURE@@@
 
Cc: primiano@chromium.org
Labels: -Type-Bug-Regression Type-Bug
Will take a look.
It's not regression since we never got results from Android bots for these tests yet.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/822db0de74c2a00f24869a50b78e461c42ac9495

commit 822db0de74c2a00f24869a50b78e461c42ac9495
Author: charliea <charliea@chromium.org>
Date: Fri Nov 18 23:11:59 2016

Revert "Enable tracing perftests on Android bots."

This reverts commit 209cf4279b5ffd543f5b2fd885544a9c7345db41.

The test is failing on all Android bots.

TBR=sullivan,dtu,eyaich1,kraynov
BUG= 656029 , 666828 

Review-Url: https://codereview.chromium.org/2513923003
Cr-Commit-Position: refs/heads/master@{#433326}

[modify] https://crrev.com/822db0de74c2a00f24869a50b78e461c42ac9495/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/822db0de74c2a00f24869a50b78e461c42ac9495/tools/perf/generate_perf_json.py

Status: Started (was: Assigned)
TL;DR *tracing_perftests* not getting built on Android bots, we try to fix it.

At the moment *tracing_perftests* running well on Linux bot because it's dependency of *chromium_builder_perf* target (defined in //src/BUILD.gn), but it doesn't work for Android because there is quite different infra pipeline (see this CL https://crrev.com/1718093003 description).

After discussion with martiniss@ and prior investigation I made an attempt to resolve it https://chromium-review.googlesource.com/c/412745/
Cc: jbudorick@chromium.org eyaich@chromium.org martiniss@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/743742be5e3ce451a4c5f1970e531a5a97a2f3ee

commit 743742be5e3ce451a4c5f1970e531a5a97a2f3ee
Author: John Budorick <jbudorick@google.com>
Date: Wed Dec 07 22:39:55 2016

Let android/builder handle dynamic test target compilation.

This also:
 - Removes the android/builder configurations for three chromium.android
   bots that were previously converted to the chromium recipe.
 - Removes chromium_android.check_webview_licenses, which had only been
   called from those bots and had been deprecated and removed from those
   bots' chromium recipe configurations.

BUG= 666828 

Change-Id: I6b63ed5eeec8269bd14a68a57af210868ae804e3
Reviewed-on: https://chromium-review.googlesource.com/417166
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/743742be5e3ce451a4c5f1970e531a5a97a2f3ee/scripts/slave/recipe_modules/chromium_android/api.py
[modify] https://crrev.com/743742be5e3ce451a4c5f1970e531a5a97a2f3ee/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/743742be5e3ce451a4c5f1970e531a5a97a2f3ee/scripts/slave/recipe_modules/chromium_tests/client_v8_fyi.py
[modify] https://crrev.com/743742be5e3ce451a4c5f1970e531a5a97a2f3ee/scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py
[delete] https://crrev.com/c17152fd954f3343991083a0d38674c05882dfc5/scripts/slave/recipes/android/builder.expected/full_chromium_android_Android_MIPS_Builder__dbg_.json
[delete] https://crrev.com/c17152fd954f3343991083a0d38674c05882dfc5/scripts/slave/recipes/android/builder.expected/full_chromium_android_Android_x64_Builder__dbg_.json
[modify] https://crrev.com/743742be5e3ce451a4c5f1970e531a5a97a2f3ee/scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_Builder.json
[modify] https://crrev.com/743742be5e3ce451a4c5f1970e531a5a97a2f3ee/scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_arm64_Builder.json
[modify] https://crrev.com/743742be5e3ce451a4c5f1970e531a5a97a2f3ee/scripts/slave/recipes/android/builder.expected/full_client_v8_fyi_Android_Builder.json
[modify] https://crrev.com/743742be5e3ce451a4c5f1970e531a5a97a2f3ee/scripts/slave/recipes/android/builder.expected/full_tryserver_chromium_perf_android_arm64_perf_bisect_builder.json
[modify] https://crrev.com/743742be5e3ce451a4c5f1970e531a5a97a2f3ee/scripts/slave/recipes/android/builder.expected/full_tryserver_chromium_perf_android_perf_bisect_builder.json
[modify] https://crrev.com/743742be5e3ce451a4c5f1970e531a5a97a2f3ee/scripts/slave/recipes/android/builder.py
[add] https://crrev.com/743742be5e3ce451a4c5f1970e531a5a97a2f3ee/scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Android_Builder.json
[rename] https://crrev.com/743742be5e3ce451a4c5f1970e531a5a97a2f3ee/scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_android_arm64_perf_bisect_builder.json
[rename] https://crrev.com/743742be5e3ce451a4c5f1970e531a5a97a2f3ee/scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_android_perf_bisect_builder.json

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e9ba1e05266a90a6c2e71c9f362aa2fd54256ba

commit 1e9ba1e05266a90a6c2e71c9f362aa2fd54256ba
Author: kraynov <kraynov@chromium.org>
Date: Fri Dec 09 15:07:36 2016

Enable tracing perftests on Android bots.

Re-landing https://crrev.com/2498113002 CL which was reverted because
bot's builder didn't build tracing_perftests target.
It has been fixed https://chromium-review.googlesource.com/c/417166 .

BUG= 656029 , 666828 

Review-Url: https://codereview.chromium.org/2562013002
Cr-Commit-Position: refs/heads/master@{#437537}

[modify] https://crrev.com/1e9ba1e05266a90a6c2e71c9f362aa2fd54256ba/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/1e9ba1e05266a90a6c2e71c9f362aa2fd54256ba/tools/perf/generate_perf_json.py

Status: Fixed (was: Started)

Sign in to add a comment