New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666827 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 666801



Sign in to add a comment

wifi_display_session_service.mojom needs to clarify what's getting sent in SendMessage / SendPacket

Project Member Reported by dcheng@chromium.org, Nov 18 2016

Issue description

Is this data supposed to be structured? Will anything in the browser process end up parsing things out of the data? These are things that need to be documented, to make it easier to audit security. Thanks!
 
SendMessage is sending text which contains an RTSP controlling message, browser process does not parse it and just immediately sends over TCP socket.

SendPacket is sending a datagram with packetized media, browser process does not parse it either (pls see extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc) but just sends it as it is over UDP socket.

Please tell what do you think is the best way to document this to make it all clear? Would just adding more comments to .mojom interfaces description be enough?


Project Member

Comment 2 by sheriffbot@chromium.org, Jun 1 2018

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
Status: Untriaged (was: Assigned)
The assigned owner "mikhail.pozdnyakov@intel.com" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: devlin@chromium.org
Status: Assigned (was: Untriaged)
devlin, can you help find an owner for improving the documentation here? I'm not sure who can own this (or what this thing even is). Basically, we just need to update the documentation in the mojom (e.g. what are wifi displays, what sort of messages need to be sent, on whose behalf are these interfaces acting for, et cetera)

Sign in to add a comment