WiFiDisplayMediaService::SetDestinationEndpoint should use net.interfaces.IPEndPoint |
|||
Issue descriptionRight now, it marshalls the port as int32_t, so it's quite easy to send an invalid port number. Since we already have a mojo struct for this, we should just reuse it.
,
Nov 24 2016
I don't know =) IPEndPoint being defined in there instead of a more generic location seems like something we'd want to fix though. +sammc for context/background info here
,
Nov 24 2016
That comment is more applicable to the interface; it's intended to be only used as an implementation detail of out-of-process proxy resolver rather than a general-purpose DNS resolver interface. At the time, we weren't pursuing mojo interfaces for the rest of //net so the types are defined by the interfaces that needed them. Moving IPEndPoint somewhere public (e.g. //net/public/interfaces) sounds good to me.
,
Nov 27 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||
►
Sign in to add a comment |
|||
Comment 1 by eero.hak...@intel.com
, Nov 24 2016