New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666823 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 666801



Sign in to add a comment

WiFiDisplayMediaService::SetDestinationEndpoint should use net.interfaces.IPEndPoint

Project Member Reported by dcheng@chromium.org, Nov 18 2016

Issue description

Right now, it marshalls the port as int32_t, so it's quite easy to send an invalid port number. Since we already have a mojo struct for this, we should just reuse it.
 
The net.interfaces.IPEndPoint is defined in //net/interfaces/host_resolver_service.mojom but that file contains a comment saying "WARNING! Do NOT use this mojom.". That instruction seems to be followed and thus that mojom is not used by any other mojom.

Should that mojom be used despite of the comment saying otherwise?

Comment 2 by dcheng@chromium.org, Nov 24 2016

Cc: sa...@chromium.org
I don't know =)

IPEndPoint being defined in there instead of a more generic location seems like something we'd want to fix though.

+sammc for context/background info here

Comment 3 by sa...@chromium.org, Nov 24 2016

That comment is more applicable to the interface; it's intended to be only used as an implementation detail of out-of-process proxy resolver rather than a general-purpose DNS resolver interface. At the time, we weren't pursuing mojo interfaces for the rest of //net so the types are defined by the interfaces that needed them.

Moving IPEndPoint somewhere public (e.g. //net/public/interfaces) sounds good to me.
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 27 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment