sdefresne@, you fixed  Issue 660343  mentioned above. Can you please take a look at this and help triage accordingly?

Thanks!

FWIW, all of the 4 most recent flakes look like this:

TextToSpeechListenerTest.ValidAudioDataTest:
2016-11-17 16:44:47.792 ios_chrome_unittests[8417:67619] Warning: Attempt to dismiss from view controller <UIViewController: 0x7ffcc0778550> while a presentation or dismiss is in progress!
2016-11-17 16:44:47.792 ios_chrome_unittests[8417:67619] Warning: Attempt to dismiss from view controller <UIViewController: 0x7ffcc0778550> while a presentation or dismiss is in progress!
../../ios/chrome/browser/voice/text_to_speech_listener_unittest.mm:50: Failure
Value of: result
  Actual: (null)
Expected: self.expectedAudioData
Which is: <74657374 6175646f 33326f69 6f>

OTOH, there are no more flakes after 2016-11-18.

+stkhapugin@ and rohitrao@ in case they can help (they've made the most recent changes to ios/chrome/browser/voice/text_to_speech_listener_unittest.mm)

Removing sheriff label. Re-add if more actions from the Chromium tree sheriffs are needed.

I have no idea why this issue was assigned to me.

Detected 5 new flakes for test/step "ios_chrome_unittests". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyHwsSBUZsYWtlIhRpb3NfY2hyb21lX3VuaXR0ZXN0cww. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Doesn't look like the flakiness is still happening in the last 200 builds. Dropped pri level and continue to monitor.

Detected 3 new flakes for test/step "ios_chrome_unittests". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyHwsSBUZsYWtlIhRpb3NfY2hyb21lX3VuaXR0ZXN0cww. This message was posted automatically by the chromium-try-flakes app.

Detected 3 new flakes for test/step "ios_chrome_unittests". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyHwsSBUZsYWtlIhRpb3NfY2hyb21lX3VuaXR0ZXN0cww. This message was posted automatically by the chromium-try-flakes app.

Sheriff here. The most recent flakes show crashes in BrowserViewWranglerTest.TestInitNilObserver, but previous flakes are also caused by failures in other tests.

Example crash:
https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/137958/steps/ios_chrome_unittests%20%28iPad%20Air%202%20iOS%2010.0%29/logs/stdio

sdefresne@, you are the only person on the blame list for that test. Could you please assign this to a more appropriate person if you cannot fix this yourself? Thanks!

Louis, as Sheriff, can you investigate.

meade: I've usptreamed most of the code from downstream iOS repository so more than 50% of the Chrome on iOS code blames to me even though I've not authored nor reviewed it.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc432f4211bfe92a50e6766d62ed8f833ab0c42d

commit dc432f4211bfe92a50e6766d62ed8f833ab0c42d
Author: sdefresne <sdefresne@chromium.org>
Date: Tue Jan 17 14:36:59 2017

Allow using a BrowserViewController without BookmarkModel for testing.

Loading the bookmarks introduce some synchronisation point (as it is
done in a background sequence) which may be the causing the flakes
of BrowserViewWranglerTest.TestInitNilObserver.

Change BrowserViewController to works if the BookmarkModel has not
been created and change the test to not create it.

BUG= 666816 

Review-Url: https://codereview.chromium.org/2632393002
Cr-Commit-Position: refs/heads/master@{#444047}

[modify] https://crrev.com/dc432f4211bfe92a50e6766d62ed8f833ab0c42d/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/dc432f4211bfe92a50e6766d62ed8f833ab0c42d/ios/chrome/browser/ui/main/browser_view_wrangler_unittest.mm

Detected 3 new flakes for test/step "ios_chrome_unittests". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyHwsSBUZsYWtlIhRpb3NfY2hyb21lX3VuaXR0ZXN0cww. This message was posted automatically by the chromium-try-flakes app.

Detected 3 new flakes for test/step "ios_chrome_unittests". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyHwsSBUZsYWtlIhRpb3NfY2hyb21lX3VuaXR0ZXN0cww. This message was posted automatically by the chromium-try-flakes app.

Detected 3 new flakes for test/step "ios_chrome_unittests". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyHwsSBUZsYWtlIhRpb3NfY2hyb21lX3VuaXR0ZXN0cww. This message was posted automatically by the chromium-try-flakes app.

Detected 10 new flakes for test/step "ios_chrome_unittests". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyHwsSBUZsYWtlIhRpb3NfY2hyb21lX3VuaXR0ZXN0cww. This message was posted automatically by the chromium-try-flakes app.

Detected 60 new flakes for test/step "ios_chrome_unittests". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyHwsSBUZsYWtlIhRpb3NfY2hyb21lX3VuaXR0ZXN0cww. This message was posted automatically by the chromium-try-flakes app.