New issue
Advanced search Search tips

Issue 666810 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Dashboard down/broken?

Project Member Reported by jbudorick@chromium.org, Nov 18 2016

Issue description

I'm getting a blank page on the flakiness dashboard, with the console showing:

http://test-results.appspot.com/builders?callback=LOAD_BUILDBOT_DATA Failed to load resource: the server responded with a status of 500 (Internal Server Error)
builders.js:79 Uncaught TypeError: Cannot read property 'webkit_tests' of undefined
    at Object.builders.getBuilders (builders.js:79)
    at loader.Loader.load (loader.js:95)
    at flakiness_dashboard.js:1611
 

Comment 1 by estaab@chromium.org, Nov 20 2016

Owner: estaab@chromium.org
Status: Started (was: Untriaged)
It came back up now too long after you reported this and I mailed out a permanent fix. https://chromium-review.googlesource.com/413142
Cc: estaab@chromium.org d...@chromium.org
 Issue 666889  has been merged into this issue.
I'm looking forward to that landing. Thanks Erik!
I've also added alerts for Flakiness Dashboard being down in issue 660849. Hopefully, we'll now be able to fix issues before users notice them.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/ba0044d3eac27f216508c461ca615436f3892b2f

commit ba0044d3eac27f216508c461ca615436f3892b2f
Author: Erik Staab <estaab@google.com>
Date: Thu Dec 01 14:01:21 2016

test-results: Remove dependency on buildbot / milo.

This changes the way we generate the list of known (master, builder, test)
tuples to use what has recently been uploaded instead of scraping step names
from recent passing buildbot builds.

The benefits to doing this are:
1) No more outages from empty builder data caused by milo queries that
timeout from being too large.
2) The javascript client will now only fetch results for combinations that
exist instead of an approximate set.
3) New test combinations will be able to upload and serve without
needing to be whitelisted.

BUG= 666889 ,659952, 655967 , 666810 , 661047 , 643944 , 405799 

Change-Id: Icd0a8a88eecbd920677f704cf816b143e7437e50
Reviewed-on: https://chromium-review.googlesource.com/413142
Commit-Queue: Erik Staab <estaab@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

[modify] https://crrev.com/ba0044d3eac27f216508c461ca615436f3892b2f/appengine/test_results/index.yaml
[delete] https://crrev.com/fb6cd3035cc307a93948a87be99320e24ece75c0/go/src/infra/appengine/test-results/buildextract/buildextract.go
[delete] https://crrev.com/fb6cd3035cc307a93948a87be99320e24ece75c0/go/src/infra/appengine/test-results/buildextract/buildextract.infra_testing
[delete] https://crrev.com/fb6cd3035cc307a93948a87be99320e24ece75c0/go/src/infra/appengine/test-results/buildextract/buildextract_test.go
[delete] https://crrev.com/fb6cd3035cc307a93948a87be99320e24ece75c0/go/src/infra/appengine/test-results/buildextract/testing.go
[delete] https://crrev.com/fb6cd3035cc307a93948a87be99320e24ece75c0/go/src/infra/appengine/test-results/buildextract/testing_test.go
[modify] https://crrev.com/ba0044d3eac27f216508c461ca615436f3892b2f/go/src/infra/appengine/test-results/cron.yaml
[modify] https://crrev.com/ba0044d3eac27f216508c461ca615436f3892b2f/go/src/infra/appengine/test-results/frontend/builders.go
[modify] https://crrev.com/ba0044d3eac27f216508c461ca615436f3892b2f/go/src/infra/appengine/test-results/frontend/builders_test.go
[modify] https://crrev.com/ba0044d3eac27f216508c461ca615436f3892b2f/go/src/infra/appengine/test-results/frontend/handlers.go

Status: Fixed (was: Started)

Sign in to add a comment