New issue
Advanced search Search tips

Issue 666809 link

Starred by 1 user
Status: Fixed
Owner:
jeffcarp@chromium.org
Closed: Nov 2016
Cc:
qyears...@chromium.org
foolip@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 657117



Sign in to add a comment

WPT Export: Script should act on one PR at a time

Project Member Reported by jeffcarp@chromium.org, Nov 18 2016 
The script should expect to be run at a regular interval (e.g. 10 mins or 1 hour). New order of operations:

- Look for an in-flight PR with the label `Chromium Export`
  - Verify that PR matches an existing Chromium commit (to guard against that label being misapplied)
  - If there is more than one PR with that label, error out
  - If a PR exists with that label:
    - If the CI is green, merge it
    - If the CI is not green, stop the script
- If there were no in-flight PRs or we just merged one:
  - Look for the next exportable commit in Chromium
  - If exists, create PR

Comment 1 by jeffcarp@chromium.org, Nov 18 2016

Labels: WPTExport

Comment 2 by jeffcarp@chromium.org, Nov 21 2016 

One complication is that it looks like wpt-stability-bot currently comments its results instead of using the PR status API (example: https://github.com/w3c/web-platform-tests/pull/4044). Maybe for a first iteration we can omit CI checking?

Comment 3 by jeffcarp@chromium.org, Nov 22 2016

Status: Started (was: Assigned)

Comment 4 by jeffcarp@chromium.org, Nov 22 2016

Blockedon: 657117
Labels: -WPTExport

Comment 5 by jeffcarp@chromium.org, Nov 22 2016

Blockedon: -657117
Blocking: 657117
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06bc68e15d0b41c94ddc85a6b5713da14561823f

commit 06bc68e15d0b41c94ddc85a6b5713da14561823f
Author: jeffcarp <jeffcarp@chromium.org>
Date: Tue Nov 29 20:34:00 2016

Refactor WPT Export to ensure only one PR in flight at a time

This CL:
- Moves out all export logic into its own class, TestExporter
- sync_wpt.py is still a shell that sets up all the classes and calls TestExporter
- Changes the 'exportable' logic to honor NOEXPORT=true
- Renames GitHub to WPTGitHub
- Adds a bunch more unit tests

This CL has not yet been tested on a real export. I hope to do a real export soon and improve/fix the code in the process.

BUG= 666809 
BUG= 666884 

Review-Url: https://codereview.chromium.org/2518313003
Cr-Commit-Position: refs/heads/master@{#435071}

[modify] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py
[modify] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_wpt.py
[modify] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_wpt_unittest.py
[delete] https://crrev.com/cb7a3e4d33a7059b2734ba7708db0116c241cb43/third_party/WebKit/Tools/Scripts/webkitpy/w3c/github.py
[delete] https://crrev.com/cb7a3e4d33a7059b2734ba7708db0116c241cb43/third_party/WebKit/Tools/Scripts/webkitpy/w3c/github_unittest.py
[modify] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
[modify] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py
[modify] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/sync_wpt.py
[add] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py
[add] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py
[add] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py
[add] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github_mock.py
[add] https://crrev.com/06bc68e15d0b41c94ddc85a6b5713da14561823f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github_unittest.py

Comment 8 by jeffcarp@chromium.org, Nov 29 2016

Status: Fixed (was: Started)
►

Sign in to add a comment