New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 666790 link

Starred by 1 user
Status: Fixed
Owner:
█ alokp@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
█ halliwell@chromium.org
█ tsunghung@chromium.org
sanfin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Plugins should not be enabled for chromecast on Android

Project Member Reported by xhw...@chromium.org, Nov 18 2016 
Today enable_plugins is true for chromecast, on both Linux and Android:

https://cs.chromium.org/chromium/src/build/config/features.gni?rcl=0&l=24

IIUIC, we don't really need to enable_plugins on Cast on Android. If we disable plugins, we might be able to save compile time and reduce binary size.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76ed9ed0d250af589239a52d427a1f72991dee71

commit 76ed9ed0d250af589239a52d427a1f72991dee71
Author: alokp <alokp@chromium.org>
Date: Thu Jan 26 00:17:44 2017

Fixes gn-check errors with enable_plugins=false.

BUG= 666790 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2655653004
Cr-Commit-Position: refs/heads/master@{#446170}

[modify] https://crrev.com/76ed9ed0d250af589239a52d427a1f72991dee71/chrome/browser/BUILD.gn
[modify] https://crrev.com/76ed9ed0d250af589239a52d427a1f72991dee71/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/76ed9ed0d250af589239a52d427a1f72991dee71/chrome/common/BUILD.gn
[modify] https://crrev.com/76ed9ed0d250af589239a52d427a1f72991dee71/chrome/common/chrome_content_client.cc
[modify] https://crrev.com/76ed9ed0d250af589239a52d427a1f72991dee71/content/browser/frame_host/debug_urls.cc
[modify] https://crrev.com/76ed9ed0d250af589239a52d427a1f72991dee71/content/browser/renderer_host/font_utils_linux.cc
[modify] https://crrev.com/76ed9ed0d250af589239a52d427a1f72991dee71/content/browser/renderer_host/render_message_filter.cc
[modify] https://crrev.com/76ed9ed0d250af589239a52d427a1f72991dee71/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/76ed9ed0d250af589239a52d427a1f72991dee71/content/browser/renderer_host/sandbox_ipc_linux.cc
[modify] https://crrev.com/76ed9ed0d250af589239a52d427a1f72991dee71/content/common/all_messages.h
[modify] https://crrev.com/76ed9ed0d250af589239a52d427a1f72991dee71/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
[modify] https://crrev.com/76ed9ed0d250af589239a52d427a1f72991dee71/content/shell/renderer/shell_content_renderer_client.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3ec364721fe2d782df068cbdd7785e4d47365fa

commit e3ec364721fe2d782df068cbdd7785e4d47365fa
Author: alokp <alokp@chromium.org>
Date: Thu Jan 26 23:05:03 2017

Fixes compile and gn-check errors with enable_plugins=false.

The component build for content_unittests and content_browsertests
were broken with enable_plugins=false on linux.

BUG= 666790 

Review-Url: https://codereview.chromium.org/2658693005
Cr-Commit-Position: refs/heads/master@{#446483}

[modify] https://crrev.com/e3ec364721fe2d782df068cbdd7785e4d47365fa/content/browser/storage_partition_impl_unittest.cc
[modify] https://crrev.com/e3ec364721fe2d782df068cbdd7785e4d47365fa/content/ppapi_plugin/BUILD.gn
[modify] https://crrev.com/e3ec364721fe2d782df068cbdd7785e4d47365fa/content/public/child/BUILD.gn

Comment 3 by alokp@chromium.org, Jan 27 2017

Status: Fixed (was: Available)
►

Sign in to add a comment