Issue metadata
Sign in to add a comment
|
The build for AArch64 Linux build is broken due to missing cast from int to enum
Reported by
ossy.sze...@gmail.com,
Nov 18 2016
|
||||||||||||||||||||||
Issue description
UserAgent: Mozilla/5.0 (Windows NT 5.1; rv:50.0) Gecko/20100101 Firefox/50.0
Steps to reproduce the problem:
../sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc:1998:23: error: no matching function for call to 'ptrace'
BPF_ASSERT_NE(-1, ptrace(PTRACE_GETREGS, pid, NULL, ®s));
^~~~~~
../sandbox/linux/seccomp-bpf/bpf_tests.h:64:48: note: expanded from macro 'BPF_ASSERT_NE'
#define BPF_ASSERT_NE(x, y) BPF_ASSERT((x) != (y))
^
../sandbox/linux/tests/unit_tests.h:107:5: note: expanded from macro 'SANDBOX_ASSERT'
((expr) ? static_cast<void>(0) : sandbox::UnitTests::AssertionFailure( \
^~~~
../build/linux/debian_jessie_arm64-sysroot/usr/include/aarch64-linux-gnu/sys/ptrace.h:190:17: note: candidate function not viable: no known conversion from 'int' to 'enum __ptrace_request' for 1st argument
extern long int ptrace (enum __ptrace_request __request, ...) __THROW;
^
../sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc:2006:29: error: no matching function for call to 'ptrace'
BPF_ASSERT_NE(-1, ptrace(PTRACE_SETREGS, pid, NULL, ®s));
^~~~~~
../sandbox/linux/seccomp-bpf/bpf_tests.h:64:48: note: expanded from macro 'BPF_ASSERT_NE'
#define BPF_ASSERT_NE(x, y) BPF_ASSERT((x) != (y))
^
../sandbox/linux/tests/unit_tests.h:107:5: note: expanded from macro 'SANDBOX_ASSERT'
((expr) ? static_cast<void>(0) : sandbox::UnitTests::AssertionFailure( \
^~~~
../build/linux/debian_jessie_arm64-sysroot/usr/include/aarch64-linux-gnu/sys/ptrace.h:190:17: note: candidate function not viable: no known conversion from 'int' to 'enum __ptrace_request' for 1st argument
extern long int ptrace (enum __ptrace_request __request, ...) __THROW;
^
../sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc:2014:27: error: no matching function for call to 'ptrace'
BPF_ASSERT_NE(-1, ptrace(PTRACE_SETREGS, pid, NULL, ®s));
^~~~~~
../sandbox/linux/seccomp-bpf/bpf_tests.h:64:48: note: expanded from macro 'BPF_ASSERT_NE'
#define BPF_ASSERT_NE(x, y) BPF_ASSERT((x) != (y))
^
../sandbox/linux/tests/unit_tests.h:107:5: note: expanded from macro 'SANDBOX_ASSERT'
((expr) ? static_cast<void>(0) : sandbox::UnitTests::AssertionFailure( \
^~~~
../build/linux/debian_jessie_arm64-sysroot/usr/include/aarch64-linux-gnu/sys/ptrace.h:190:17: note: candidate function not viable: no known conversion from 'int' to 'enum __ptrace_request' for 1st argument
extern long int ptrace (enum __ptrace_request __request, ...) __THROW;
^
3 errors generated.
What is the expected behavior?
What went wrong?
build
Did this work before? N/A
Chrome version: Channel: n/a
OS Version:
Flash Version:
,
Nov 18 2016
,
Nov 22 2016
Adding the current Dev milestone. Please close the issue once the build succeeds.
,
Nov 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/033fbea1cde6401bacabe4b721f21ba41215ee23 commit 033fbea1cde6401bacabe4b721f21ba41215ee23 Author: ossy.szeged <ossy.szeged@gmail.com> Date: Wed Nov 23 11:32:29 2016 Aarch64 buildfix. Cast ints to the proper enum type to make clang happy. BUG= 666780 Review-Url: https://codereview.chromium.org/2512073003 Cr-Commit-Position: refs/heads/master@{#434145} [modify] https://crrev.com/033fbea1cde6401bacabe4b721f21ba41215ee23/sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc
,
Nov 24 2016
,
Nov 27 2016
so presumably this is now fixed with #4? If not, please reopen |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ossy.sze...@gmail.com
, Nov 18 2016