New issue
Advanced search Search tips

Issue 666776 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature

Blocking:
issue 666773



Sign in to add a comment

Remove is_chromeos blocks from ash BUILD.gn files

Project Member Reported by jamescook@chromium.org, Nov 18 2016

Issue description

We're dropping support for ash_unittests on Windows and non-chromeos Linux. Simplify the build files.

 
Related in chrome/test/BUILD.gn

    if (!is_chromeos && use_ash) {
      sources -= [
        # On Windows and Linux, we currently don't support enough of the
        # ash environment to run these unit tests.

Owner: jamescook@chromium.org
Status: Started (was: Untriaged)
https://codereview.chromium.org/2559713003
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19296fdd4d9f60b86c38b98bc926b10dc9571947

commit 19296fdd4d9f60b86c38b98bc926b10dc9571947
Author: jamescook <jamescook@chromium.org>
Date: Fri Dec 09 01:23:47 2016

Remove non-chromeos support from src/ash BUILD.gn files

Ash only ships on Chrome OS, so simplify our BUILD.gn files by removing
all the is_win and is_chromeos conditionals.

TODO: ash/resources/BUILD.gn. Right now chrome/browser/ui has a dependency
on ash resources for aura builds on all platforms.

BUG= 666776 
TEST=bots

Review-Url: https://codereview.chromium.org/2559713003
Cr-Commit-Position: refs/heads/master@{#437408}

[modify] https://crrev.com/19296fdd4d9f60b86c38b98bc926b10dc9571947/ash/BUILD.gn
[modify] https://crrev.com/19296fdd4d9f60b86c38b98bc926b10dc9571947/ash/common/BUILD.gn
[modify] https://crrev.com/19296fdd4d9f60b86c38b98bc926b10dc9571947/ash/common/strings/BUILD.gn
[modify] https://crrev.com/19296fdd4d9f60b86c38b98bc926b10dc9571947/ash/mus/BUILD.gn
[modify] https://crrev.com/19296fdd4d9f60b86c38b98bc926b10dc9571947/ash/test/BUILD.gn

Left to do:

ash/resources/BUILD.gn (use_aura)
chrome/test/BUILD.gn (see comment #1)

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1ba845fac867bce029d97d9a54050b31807244c

commit d1ba845fac867bce029d97d9a54050b31807244c
Author: jamescook <jamescook@chromium.org>
Date: Tue Dec 13 00:56:50 2016

Remove non-chromeos support from src/ash/resources/BUILD.gn

Ash only ships on Chrome OS, so simplify our BUILD.gn files by removing
all the is_win and is_chromeos conditionals.

This also removes a dependency from chrome/browser/ui/BUILD.gn that existed
for all use_aura builds. Aura should not require ash on Windows or Linux.

BUG= 666776 
TEST=bots

Review-Url: https://codereview.chromium.org/2569723003
Cr-Commit-Position: refs/heads/master@{#437973}

[modify] https://crrev.com/d1ba845fac867bce029d97d9a54050b31807244c/ash/resources/BUILD.gn
[modify] https://crrev.com/d1ba845fac867bce029d97d9a54050b31807244c/chrome/browser/ui/BUILD.gn

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a81b59b30f523ae825654f7ddc44a95ecd77f0c

commit 3a81b59b30f523ae825654f7ddc44a95ecd77f0c
Author: jamescook <jamescook@chromium.org>
Date: Wed Dec 14 04:14:19 2016

Clean up chrome/test/BUILD.gn for Chrome OS and ash

Ash only ships on Chrome OS, so simplify the BUILD.gn file by removing
cases that assume use_ash but !is_chromeos.

BUG= 666776 
TEST=bots

Review-Url: https://codereview.chromium.org/2577493002
Cr-Commit-Position: refs/heads/master@{#438426}

[modify] https://crrev.com/3a81b59b30f523ae825654f7ddc44a95ecd77f0c/chrome/test/BUILD.gn

Status: Fixed (was: Started)
There's a separate bug for collapsing use_ash and is_chromeos.

Comment 8 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59
Labels: code-change
Status: Verified (was: Fixed)

Sign in to add a comment