Remove is_chromeos blocks from ash BUILD.gn files |
||||||
Issue descriptionWe're dropping support for ash_unittests on Windows and non-chromeos Linux. Simplify the build files.
,
Dec 8 2016
https://codereview.chromium.org/2559713003
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19296fdd4d9f60b86c38b98bc926b10dc9571947 commit 19296fdd4d9f60b86c38b98bc926b10dc9571947 Author: jamescook <jamescook@chromium.org> Date: Fri Dec 09 01:23:47 2016 Remove non-chromeos support from src/ash BUILD.gn files Ash only ships on Chrome OS, so simplify our BUILD.gn files by removing all the is_win and is_chromeos conditionals. TODO: ash/resources/BUILD.gn. Right now chrome/browser/ui has a dependency on ash resources for aura builds on all platforms. BUG= 666776 TEST=bots Review-Url: https://codereview.chromium.org/2559713003 Cr-Commit-Position: refs/heads/master@{#437408} [modify] https://crrev.com/19296fdd4d9f60b86c38b98bc926b10dc9571947/ash/BUILD.gn [modify] https://crrev.com/19296fdd4d9f60b86c38b98bc926b10dc9571947/ash/common/BUILD.gn [modify] https://crrev.com/19296fdd4d9f60b86c38b98bc926b10dc9571947/ash/common/strings/BUILD.gn [modify] https://crrev.com/19296fdd4d9f60b86c38b98bc926b10dc9571947/ash/mus/BUILD.gn [modify] https://crrev.com/19296fdd4d9f60b86c38b98bc926b10dc9571947/ash/test/BUILD.gn
,
Dec 9 2016
Left to do: ash/resources/BUILD.gn (use_aura) chrome/test/BUILD.gn (see comment #1)
,
Dec 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1ba845fac867bce029d97d9a54050b31807244c commit d1ba845fac867bce029d97d9a54050b31807244c Author: jamescook <jamescook@chromium.org> Date: Tue Dec 13 00:56:50 2016 Remove non-chromeos support from src/ash/resources/BUILD.gn Ash only ships on Chrome OS, so simplify our BUILD.gn files by removing all the is_win and is_chromeos conditionals. This also removes a dependency from chrome/browser/ui/BUILD.gn that existed for all use_aura builds. Aura should not require ash on Windows or Linux. BUG= 666776 TEST=bots Review-Url: https://codereview.chromium.org/2569723003 Cr-Commit-Position: refs/heads/master@{#437973} [modify] https://crrev.com/d1ba845fac867bce029d97d9a54050b31807244c/ash/resources/BUILD.gn [modify] https://crrev.com/d1ba845fac867bce029d97d9a54050b31807244c/chrome/browser/ui/BUILD.gn
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a81b59b30f523ae825654f7ddc44a95ecd77f0c commit 3a81b59b30f523ae825654f7ddc44a95ecd77f0c Author: jamescook <jamescook@chromium.org> Date: Wed Dec 14 04:14:19 2016 Clean up chrome/test/BUILD.gn for Chrome OS and ash Ash only ships on Chrome OS, so simplify the BUILD.gn file by removing cases that assume use_ash but !is_chromeos. BUG= 666776 TEST=bots Review-Url: https://codereview.chromium.org/2577493002 Cr-Commit-Position: refs/heads/master@{#438426} [modify] https://crrev.com/3a81b59b30f523ae825654f7ddc44a95ecd77f0c/chrome/test/BUILD.gn
,
Dec 14 2016
There's a separate bug for collapsing use_ash and is_chromeos.
,
Mar 4 2017
,
Apr 17 2017
,
May 8 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jamescook@chromium.org
, Dec 1 2016Related in chrome/test/BUILD.gn if (!is_chromeos && use_ash) { sources -= [ # On Windows and Linux, we currently don't support enough of the # ash environment to run these unit tests.