New issue
Advanced search Search tips

Issue 666775 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 666773



Sign in to add a comment

Remove ash_unittests from non-chromeos build bots

Project Member Reported by jamescook@chromium.org, Nov 18 2016

Issue description

We're dropping support for ash_unittests on Windows and non-chromeos Linux. Take the suite off the bots.

 
Owner: jamescook@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4df6f882339a191a91fe3bebd87a9648f648b095

commit 4df6f882339a191a91fe3bebd87a9648f648b095
Author: jamescook <jamescook@chromium.org>
Date: Thu Dec 01 18:42:56 2016

Take ash_unitests and mash_unittests off the Windows bots

Ash has not shipped on Windows for years so we're removing support.

BUG= 666775 
TEST=bots

Review-Url: https://codereview.chromium.org/2546783003
Cr-Commit-Position: refs/heads/master@{#435658}

[modify] https://crrev.com/4df6f882339a191a91fe3bebd87a9648f648b095/testing/buildbot/chromium.win.json

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd26c0e297befc4e6dae395ab2914f7840c82804

commit bd26c0e297befc4e6dae395ab2914f7840c82804
Author: jamescook <jamescook@chromium.org>
Date: Fri Dec 02 00:21:12 2016

Take ash_content_unitests off the Windows bots

Ash has not shipped on Windows for years so we're removing support.

BUG= 666775 
TEST=bots
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2535303008
Cr-Commit-Position: refs/heads/master@{#435788}

[modify] https://crrev.com/bd26c0e297befc4e6dae395ab2914f7840c82804/testing/buildbot/chromium.win.json

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c02a0b830b3ee86df411772408344a926c52a86

commit 4c02a0b830b3ee86df411772408344a926c52a86
Author: jamescook <jamescook@chromium.org>
Date: Fri Dec 02 23:14:42 2016

Remove ash_unittests/mash_unittests from the Windows build

Ash has not shipped on Windows for years so we're removing support. A previous
CL stopped running these tests on the Windows bots.

This also removes the test build targets on Linux, but we have never shipped
ash on non-chromeos Linux, and those tests have never run on the bots.

Future CLs will clean up use_ash vs. is_win vs. is_chromeos in BUILD.gn files.

BUG= 666775 
TEST=bots

Review-Url: https://codereview.chromium.org/2549583002
Cr-Commit-Position: refs/heads/master@{#436074}

[modify] https://crrev.com/4c02a0b830b3ee86df411772408344a926c52a86/BUILD.gn
[modify] https://crrev.com/4c02a0b830b3ee86df411772408344a926c52a86/ash/BUILD.gn
[modify] https://crrev.com/4c02a0b830b3ee86df411772408344a926c52a86/ash/common/BUILD.gn
[modify] https://crrev.com/4c02a0b830b3ee86df411772408344a926c52a86/ash/mus/BUILD.gn
[modify] https://crrev.com/4c02a0b830b3ee86df411772408344a926c52a86/chrome/tools/build/win/create_installer_archive.py
[modify] https://crrev.com/4c02a0b830b3ee86df411772408344a926c52a86/mash/BUILD.gn
[modify] https://crrev.com/4c02a0b830b3ee86df411772408344a926c52a86/mash/example/BUILD.gn
[modify] https://crrev.com/4c02a0b830b3ee86df411772408344a926c52a86/mash/session/BUILD.gn
[modify] https://crrev.com/4c02a0b830b3ee86df411772408344a926c52a86/tools/determinism/deterministic_build_whitelist.pyl

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00d50f2e63ac31615026ad0f09e3a7b196fde53d

commit 00d50f2e63ac31615026ad0f09e3a7b196fde53d
Author: tonikitoo <tonikitoo@igalia.com>
Date: Fri Jan 06 18:19:00 2017

nogncheck some includes guarded under OS_CHROMEOS

Past [1], 'ash/*' became a dependency tiedly coupled with
'is_chromeos'. This, for various reasons, helped to simplify the
dependency tree of mus+ash.

However, with the introduction of simple_wm [2], it should still be
possible to build and run Chrome/Ozone targeting LinuxOS
(not ChromeOS), with 'enable_package_mash_services' ON.

For that, this CL eases the gn checks for CHROMEOS specific header
inclusions in mash/package/mash_packaged_service.cc.

TEST=<out>/chrome --mash --ozone-platform={x11|wayland} --window-manager=simple_wm

[1] https://codereview.chromium.org/2549583002
[2] https://codereview.chromium.org/2511233002

BUG= 666775 

Review-Url: https://codereview.chromium.org/2620503002
Cr-Commit-Position: refs/heads/master@{#441978}

[modify] https://crrev.com/00d50f2e63ac31615026ad0f09e3a7b196fde53d/mash/package/mash_packaged_service.cc

Comment 7 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58
Labels: mash

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59
Labels: code-change
Status: Verified (was: Fixed)

Sign in to add a comment