New issue
Advanced search Search tips

Issue 666764 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 665882
Owner: ----
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

CQ fails to commit TBR'd patch w/out a "+1" code review.

Project Member Reported by d...@chromium.org, Nov 18 2016

Issue description

When submitting this issue: https://chromium-review.googlesource.com/c/412301/

I passed presubmit, but received a message from CQ saying that it couldn't submit it:
Failed to submit 1 change due to the following problems:
Change 412301: needs Code-Review

Please, unvote/vote on Commit Queue label to re-trigger on the same patchset.
Bot data: {"action": "cancel", "triggered_at": "2016-11-18T16:17:42.0Z", "revision": "c27b9da9466439d98b42b35718ddc08d7b4217de"}


This is not an expected behavior, as Rietveld CQ did not require an explicit "LGTM" before it was willing to commit. This looks like a Gerrit-side error? I think updating the CQ TBR logic to:
- Check if someone has +1'd the change.
- Add its own +1 code review if not.
- Then proceed with submit.

... is appropriate here.
 

Comment 1 by d...@chromium.org, Nov 18 2016

Having witnessed a CL uploaded by "git cl upload" auto-add a +1 b/c of TBR, I think I have more of the picture now. This CL was edited using the Gerrit inline editor to add the "TBR" to the commit message. This is something that can also be done in Rietveld. Because of this, the "git cl upload" hook for +1 obviously didn't fire.

I still think the proposed solution above is a good idea.
Mergedinto: 665882
Status: Duplicate (was: Untriaged)
Thanks, Dan, for yet another proof for my PoV here:  http://crbug.com/665882  

Sign in to add a comment