When submitting this issue: https://chromium-review.googlesource.com/c/412301/
I passed presubmit, but received a message from CQ saying that it couldn't submit it:
Failed to submit 1 change due to the following problems:
Change 412301: needs Code-Review
Please, unvote/vote on Commit Queue label to re-trigger on the same patchset.
Bot data: {"action": "cancel", "triggered_at": "2016-11-18T16:17:42.0Z", "revision": "c27b9da9466439d98b42b35718ddc08d7b4217de"}
This is not an expected behavior, as Rietveld CQ did not require an explicit "LGTM" before it was willing to commit. This looks like a Gerrit-side error? I think updating the CQ TBR logic to:
- Check if someone has +1'd the change.
- Add its own +1 code review if not.
- Then proceed with submit.
... is appropriate here.
Comment 1 by d...@chromium.org
, Nov 18 2016