New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666749 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Team-Security-UX



Sign in to add a comment

Security indicators: size and position of Android icons slightly off

Project Member Reported by maxwalker@chromium.org, Nov 18 2016

Issue description

On Android the icon size/spacing is slightly off. Please see attached image.
Assets and specs in: "Chrome Omnibox & Security > Touch > Assets" (https://drive.google.com/corp/drive/u/0/folders/0B6Wxmj9LZL6XSHdBVUlQaDdTamc)

Related issue (wrong assets on iOS): https://bugs.chromium.org/p/chromium/issues/detail?id=646665.

Thanks for looking into this!
 
Android Icons.png
253 KB View Download
Cc: est...@chromium.org
Lucas/Emily -- I know Adrienne added the Clank changes -- are either of you familiar with the Clank code for this? (or would this be more appropriate for someone else?
Cc: -lgar...@chromium.org
Owner: lgar...@chromium.org
Status: Started (was: Untriaged)
This has been bothering me a lot. Y'all just put me in charge of icons next time. :-P

The files are here; should be easy to change: https://cs.chromium.org/search/?q=omnibox_https_valid&sq=package:chromium&type=cs
https://codereview.chromium.org/2519533002

Max, that folder contains `omnibox_http_black-xhdpi  (1).png`, could you rename that to `omnibox_http_black-xhdpi.png`?
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c087c64c1e08c1c3cc8b529d77fbb097dc9fc103

commit c087c64c1e08c1c3cc8b529d77fbb097dc9fc103
Author: lgarron <lgarron@chromium.org>
Date: Sat Nov 19 03:21:26 2016

Update security indicator icons on Android to match spec assets.

BUG= 666749 

Review-Url: https://codereview.chromium.org/2519533002
Cr-Commit-Position: refs/heads/master@{#433387}

[modify] https://crrev.com/c087c64c1e08c1c3cc8b529d77fbb097dc9fc103/chrome/android/java/res/drawable-hdpi/omnibox_https_invalid.png
[modify] https://crrev.com/c087c64c1e08c1c3cc8b529d77fbb097dc9fc103/chrome/android/java/res/drawable-hdpi/omnibox_https_valid.png
[modify] https://crrev.com/c087c64c1e08c1c3cc8b529d77fbb097dc9fc103/chrome/android/java/res/drawable-hdpi/omnibox_info.png
[modify] https://crrev.com/c087c64c1e08c1c3cc8b529d77fbb097dc9fc103/chrome/android/java/res/drawable-mdpi/omnibox_https_invalid.png
[modify] https://crrev.com/c087c64c1e08c1c3cc8b529d77fbb097dc9fc103/chrome/android/java/res/drawable-mdpi/omnibox_https_valid.png
[modify] https://crrev.com/c087c64c1e08c1c3cc8b529d77fbb097dc9fc103/chrome/android/java/res/drawable-mdpi/omnibox_info.png
[modify] https://crrev.com/c087c64c1e08c1c3cc8b529d77fbb097dc9fc103/chrome/android/java/res/drawable-xhdpi/omnibox_https_invalid.png
[modify] https://crrev.com/c087c64c1e08c1c3cc8b529d77fbb097dc9fc103/chrome/android/java/res/drawable-xhdpi/omnibox_https_valid.png
[modify] https://crrev.com/c087c64c1e08c1c3cc8b529d77fbb097dc9fc103/chrome/android/java/res/drawable-xhdpi/omnibox_info.png
[modify] https://crrev.com/c087c64c1e08c1c3cc8b529d77fbb097dc9fc103/chrome/android/java/res/drawable-xxhdpi/omnibox_https_invalid.png
[modify] https://crrev.com/c087c64c1e08c1c3cc8b529d77fbb097dc9fc103/chrome/android/java/res/drawable-xxhdpi/omnibox_https_valid.png
[modify] https://crrev.com/c087c64c1e08c1c3cc8b529d77fbb097dc9fc103/chrome/android/java/res/drawable-xxhdpi/omnibox_info.png
[modify] https://crrev.com/c087c64c1e08c1c3cc8b529d77fbb097dc9fc103/chrome/android/java/res/drawable-xxxhdpi/omnibox_https_invalid.png
[modify] https://crrev.com/c087c64c1e08c1c3cc8b529d77fbb097dc9fc103/chrome/android/java/res/drawable-xxxhdpi/omnibox_https_valid.png
[modify] https://crrev.com/c087c64c1e08c1c3cc8b529d77fbb097dc9fc103/chrome/android/java/res/drawable-xxxhdpi/omnibox_info.png

Status: Fixed (was: Started)
maxwalker@: As on iOS, the vertical baseline alignment is half a pixel off. I presume that's okay?
good.png
192 KB View Download
neutral.png
196 KB View Download
bad.png
118 KB View Download
good-old.png
182 KB View Download
Labels: Needs-TestConfirmation
TEST=Do the following on both an Android phone and an Android tablet:

1) Visit google.com
2) visit expired.badssl.com

In both cases, the baseline of the security icon on the left of the omnibox (lock or danger triangle) should be almost exactly aligned with the URL.
Components: -Security>UX
Labels: -Team-Security-UX
Thank you!

>> Max, that folder contains `omnibox_http_black-xhdpi  (1).png`, could you rename that to `omnibox_http_black-xhdpi.png`?
I can't find the "...(1).png" file. Is it still there?

>> maxwalker@: As on iOS, the vertical baseline alignment is half a pixel off. I presume that's okay?
Yes, this is ok. See attached image at high zoom level ("Baseline.png").

I noticed that the spacing between the icon and the URL is still incorrect. It should be 8dp on either side of the icon. See attached images. Could you take a look? Thanks!
Baseline.png
57.7 KB View Download
SPECS-Phone-toolbar-menu-fip-04.png
316 KB View Download
Comparison.png
88.7 KB View Download

Sign in to add a comment