New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666741 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

(location_) != nullptr in handles.cc

Project Member Reported by ClusterFuzz, Nov 18 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5087476927692800

Fuzzer: mbarbella_js_mutation
Job Type: linux_asan_d8_v8_arm64_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  (location_) != nullptr in handles.cc
  
Regressed: V8: r41088:41089

Minimized Testcase (0.08 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv94lsgXbM71SPAjIK9OooYH_BZhK5I1u4YmbQLSsUwehOBGDEJesljxYmH5EIC8-P4-XymxzAuJgww5DEPvAlBg76eQe2RdsHYwxqhcATl1JaxLPeEpeNXPPS2x0TMKW3_N9KUCWdFjX_0WZ4fg32VCcDI1_cg?testcase_id=5087476927692800
(function __f_7() {
  let memory = new WebAssembly.Memory({initial: 59199});
})();


Issue manually filed by: ishell

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by ishell@chromium.org, Nov 18 2016

Cc: ishell@chromium.org titzer@chromium.org jochen@chromium.org
Owner: eholk@chromium.org
Status: Assigned (was: Untriaged)
CF points to https://codereview.chromium.org/2396433008
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d0fe942d2304655f587f49a0b6a1c9a079692912

commit d0fe942d2304655f587f49a0b6a1c9a079692912
Author: eholk <eholk@chromium.org>
Date: Mon Nov 21 21:58:35 2016

[wasm] Throw a RangeError if Wasm memory could not be allocated.

This fixes a bug found by the fuzzer where we would attempt to
dereference a null handle if memory allocation failed. In this case,
the failure was because the amount of memory requested was above V8's
hardcoded limit.

BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=666741

Review-Url: https://codereview.chromium.org/2514983002
Cr-Commit-Position: refs/heads/master@{#41158}

[modify] https://crrev.com/d0fe942d2304655f587f49a0b6a1c9a079692912/src/wasm/wasm-js.cc
[add] https://crrev.com/d0fe942d2304655f587f49a0b6a1c9a079692912/test/mjsunit/regress/wasm/regression-666741.js

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d0fe942d2304655f587f49a0b6a1c9a079692912

commit d0fe942d2304655f587f49a0b6a1c9a079692912
Author: eholk <eholk@chromium.org>
Date: Mon Nov 21 21:58:35 2016

[wasm] Throw a RangeError if Wasm memory could not be allocated.

This fixes a bug found by the fuzzer where we would attempt to
dereference a null handle if memory allocation failed. In this case,
the failure was because the amount of memory requested was above V8's
hardcoded limit.

BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=666741

Review-Url: https://codereview.chromium.org/2514983002
Cr-Commit-Position: refs/heads/master@{#41158}

[modify] https://crrev.com/d0fe942d2304655f587f49a0b6a1c9a079692912/src/wasm/wasm-js.cc
[add] https://crrev.com/d0fe942d2304655f587f49a0b6a1c9a079692912/test/mjsunit/regress/wasm/regression-666741.js

Project Member

Comment 4 by ClusterFuzz, Nov 22 2016

ClusterFuzz has detected this issue as fixed in range 41157:41158.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5087476927692800

Fuzzer: mbarbella_js_mutation
Job Type: linux_asan_d8_v8_arm64_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  (location_) != nullptr in handles.cc
  
Regressed: V8: r41088:41089
Fixed: V8: r41157:41158

Minimized Testcase (0.08 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv94lsgXbM71SPAjIK9OooYH_BZhK5I1u4YmbQLSsUwehOBGDEJesljxYmH5EIC8-P4-XymxzAuJgww5DEPvAlBg76eQe2RdsHYwxqhcATl1JaxLPeEpeNXPPS2x0TMKW3_N9KUCWdFjX_0WZ4fg32VCcDI1_cg?testcase_id=5087476927692800
(function __f_7() {
  let memory = new WebAssembly.Memory({initial: 59199});
})();


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Nov 22 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment