Further automate WebRTC rolls |
|||||
Issue descriptionFor more frequent rolls into Chrome, I would like us to consider writing a semi automated script that a sheriff could have running: * Everything the script does, it does as the currently logged in user. * The script assumes it 'owns' a checkout (i.e. the user does not do any work in the checkout while the script is running) * Assuming a roll is not already in progress, the script polls for new CLs being checked in and then does one of: * Checking the state of the FYI builders for that revision, if all is green start a roll. * Prepare a roll and start a dry run. * Once all try bots have finished, check if they're all green and the FYI bots are as well. * Either commit or abort the roll depending on the state of the bots. * Repeat
,
Nov 18 2016
I've been giving this a lot of thinking in the past, and we should really have a bot that does all this (similar to the bot we have for rolling chromium_revision in DEPS). I created a CL for that a year ago (https://codereview.chromium.org/1384273003/) but it wasn't possible to deploy due to the LKGR not being able to incorporate the status of the chromium.webrtc + chromium.webrtc.fyi bots (which is essentially what we're talking about here with "Checking the state of the FYI builders for that revision"). I tried updating the lkgr finder in https://codereview.chromium.org/1416773007 but had to revert that, since it doesn't work as long as the got_revision property for the builders in chromium.webrtc.fyi is a Chromium revision. Changing got_revision to be the WebRTC revision is easy, but it will have the side-effect of breaking the perf dashboard data reporting which is based on it. Luckily, all the above problems are very related to my Q4 OKR task of fixing the revision reporting to the perf dashboard for these bots, so I might be able to resolve it once I've gotten some time to dig into this hairy code again.
,
Dec 16 2016
Once we get this fixed, it would be nice with an overview like https://autoroll.skia.org/ for this.
,
Apr 24 2017
Assigning to Edward since this is now a Q2 OKR. This is also blocked on getting our full Git repo into src/third_party/webrtc, which is described in go/webrtc-repo-in-chrome (tracked in bug 611808 ).
,
Jun 20 2017
See http://crbug.com/664042 for how to deploy credentials to slave23-c3 for the "Auto-roll - Chrome DEPS" builder once it's created.
,
Sep 26 2017
I added bug 539527 as blocking (but it's resolved) to showcase that we have an account we can use for this: webrtc-autoroll@chromium.org
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/eb66fcfca8ab2e4b112f56a3bca9943ebe8aa275 commit eb66fcfca8ab2e4b112f56a3bca9943ebe8aa275 Author: Edward Lemur <ehmaldonado@chromium.org> Date: Tue Sep 26 11:51:49 2017 Add WebRTC to lkgr_finder recipe. TBR=phajdan.jr@chromium.org Bug: 666726 Change-Id: I28d819fcfc2a14eeefacb2e7a0f542bfe0233236 Reviewed-on: https://chromium-review.googlesource.com/681475 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Henrik Kjellander <kjellander@chromium.org> [modify] https://crrev.com/eb66fcfca8ab2e4b112f56a3bca9943ebe8aa275/recipes/recipes/lkgr_finder.py [modify] https://crrev.com/eb66fcfca8ab2e4b112f56a3bca9943ebe8aa275/recipes/README.recipes.md [add] https://crrev.com/eb66fcfca8ab2e4b112f56a3bca9943ebe8aa275/recipes/recipes/lkgr_finder.expected/webrtc_manual.json [add] https://crrev.com/eb66fcfca8ab2e4b112f56a3bca9943ebe8aa275/recipes/recipes/lkgr_finder.expected/webrtc.json
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/1cabe256b0fddac530e4ac0f5e8a350e172e7c63 commit 1cabe256b0fddac530e4ac0f5e8a350e172e7c63 Author: Edward Lemur <ehmaldonado@chromium.org> Date: Tue Sep 26 14:53:47 2017 Add chromium.webrtc.fyi bots to WebRTC LKGR config. Bug: 666726 Change-Id: Ib171b60873d88f67bb45fddfc4a2555df9cfab17 Reviewed-on: https://chromium-review.googlesource.com/684837 Reviewed-by: Henrik Kjellander <kjellander@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> [modify] https://crrev.com/1cabe256b0fddac530e4ac0f5e8a350e172e7c63/infra/services/lkgr_finder/config/webrtc_cfg.pyl
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/912da68f0a273db45e955d3949e4074095b47159 commit 912da68f0a273db45e955d3949e4074095b47159 Author: Edward Lemur <ehmaldonado@chromium.org> Date: Tue Sep 26 17:43:48 2017 WebRTC: Add lkgr finder bot. Bug: 666726 Change-Id: I2c4f0e29a8968f1b640d761b4602393a058a95ba Reviewed-on: https://chromium-review.googlesource.com/684994 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Henrik Kjellander <kjellander@chromium.org> [modify] https://crrev.com/912da68f0a273db45e955d3949e4074095b47159/masters/master.client.webrtc.fyi/slaves.cfg [modify] https://crrev.com/912da68f0a273db45e955d3949e4074095b47159/masters/master.client.webrtc.fyi/master_linux_cfg.py
,
Oct 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/1226c83cc8d71ceca30fd0a3afa3e3c24bc1169f commit 1226c83cc8d71ceca30fd0a3afa3e3c24bc1169f Author: Edward Lemur <ehmaldonado@chromium.org> Date: Thu Oct 05 15:45:14 2017 Update LKGR revision every 15 minutes. Bug: 666726 Change-Id: I0d70424e33b28c899d9d0cae8568b75fbc340aa8 Reviewed-on: https://chromium-review.googlesource.com/701194 Reviewed-by: Henrik Kjellander <kjellander@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> [modify] https://crrev.com/1226c83cc8d71ceca30fd0a3afa3e3c24bc1169f/masters/master.client.webrtc.fyi/master_linux_cfg.py [modify] https://crrev.com/1226c83cc8d71ceca30fd0a3afa3e3c24bc1169f/masters/master.client.webrtc.fyi/master.cfg
,
Oct 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/0770743c4d125faa22826983bbe6c8913db61447 commit 0770743c4d125faa22826983bbe6c8913db61447 Author: Edward Lemur <ehmaldonado@chromium.org> Date: Thu Oct 05 16:27:05 2017 WebRTC: Update LKGR revision every 5 minutes. TBR=kjellander@chromium.org Bug: 666726 Change-Id: Ibe4dfe022f82318c1a3badebb670fabf6a6e9a28 Reviewed-on: https://chromium-review.googlesource.com/702266 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> [modify] https://crrev.com/0770743c4d125faa22826983bbe6c8913db61447/masters/master.client.webrtc.fyi/master_linux_cfg.py
,
Oct 5 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/puppet/+/593ebba83d10279ac1bda5841f3ed0c4718e4af0 commit 593ebba83d10279ac1bda5841f3ed0c4718e4af0 Author: Edward Lemur <ehmaldonado@google.com> Date: Thu Oct 05 18:20:48 2017
,
Jan 19 2018
This is fixed, no?
,
Jan 19 2018
Yup |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kjellander@chromium.org
, Nov 18 2016