AutofillManagerTest is flaky |
||||||||||||
Issue description"AutofillManagerTest.UploadCreditCard_CvcUnavailable" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPgsSBUZsYWtlIjNBdXRvZmlsbE1hbmFnZXJUZXN0LlVwbG9hZENyZWRpdENhcmRfQ3ZjVW5hdmFpbGFibGUM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Nov 18 2016
Renaming to "AutofillManagerTest is flaky". The flakes from this bug and from issue 666648 are both part of a larger flake of AutofillManagerTest, including: ======================================================== AutofillManagerTest.UploadCreditCard SSLErrorClassificationTest.GetClockState AutofillManagerTest.CreditCardSavedWhenAutocompleteOff AutofillManagerTest.UploadCreditCard_FeatureNotEnabled AutofillManagerTest.UploadCreditCard_NoNameAvailable AutofillManagerTest.UploadCreditCard_NamesHaveToMatch DataReductionProxyInterceptorEndToEndTest.RedirectChainToHttps AutofillManagerTest.UploadCreditCard_NoProfileAvailable AutofillManagerTest.ImportFormDataCreditCardHTTP SSLErrorClassificationTest.NetworkClockStateHistogram AutofillManagerTest.UploadCreditCard_NoZipCodeAvailable AutofillManagerTest.UploadCreditCard_ZipCodesConflict AutofillManagerTest.UploadCreditCard_NamesMatchLoosely AutofillManagerTest.UploadCreditCard_UploadDetailsFails AutofillManagerTest.UploadCreditCard_ZipCodesHavePrefixMatch AutofillManagerTest.UploadCreditCard_CvcUnavailable AutofillManagerTest.UploadCreditCard_MultipleCvcFields AutofillManagerTest.ImportFormDataCreditCardHTTPS ======================================================== Most failures are on EXPECT_TRUE(...->credit_card_was_uploaded()), in other cases a missing EXPECT_CALL(). But the high-level issue is the same - saving/uploading of a card fails; and when it does, it does so in all affected tests.
,
Nov 18 2016
One thing I see that could cause the flakiness is
WaitForAsyncUploadProcess() { run_loop_->Run(); }
if the condition we're waiting is actually something else than just running out of tasks.
mathp@, can you have a look or route this within the autofill team?
,
Nov 22 2016
Detected 3 new flakes for test/step "AutofillManagerTest.UploadCreditCard_CvcUnavailable". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPgsSBUZsYWtlIjNBdXRvZmlsbE1hbmFnZXJUZXN0LlVwbG9hZENyZWRpdENhcmRfQ3ZjVW5hdmFpbGFibGUM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Nov 22 2016
,
Nov 23 2016
Issue 668009 has been merged into this issue.
,
Nov 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24489dbd083c57720618e2c84830cd94fd0bf877 commit 24489dbd083c57720618e2c84830cd94fd0bf877 Author: mathp <mathp@chromium.org> Date: Wed Nov 23 19:57:30 2016 [Autofill] Disable flaky AutofillManagerTest.UploadCreditCard* tests They are flaky. BUG= 666704 TEST=AutofillManagerTest Review-Url: https://codereview.chromium.org/2528723002 Cr-Commit-Position: refs/heads/master@{#434229} [modify] https://crrev.com/24489dbd083c57720618e2c84830cd94fd0bf877/components/autofill/core/browser/autofill_manager_unittest.cc
,
Nov 23 2016
Thanks for disabling the tests.
,
Nov 23 2016
Detected 3 new flakes for test/step "AutofillManagerTest.ImportFormDataCreditCardHTTPS". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPAsSBUZsYWtlIjFBdXRvZmlsbE1hbmFnZXJUZXN0LkltcG9ydEZvcm1EYXRhQ3JlZGl0Q2FyZEhUVFBTDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Nov 26 2016
Detected 3 new flakes for test/step "AutofillManagerTest.ImportFormDataCreditCardHTTPS". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPAsSBUZsYWtlIjFBdXRvZmlsbE1hbmFnZXJUZXN0LkltcG9ydEZvcm1EYXRhQ3JlZGl0Q2FyZEhUVFBTDA. This message was posted automatically by the chromium-try-flakes app.
,
Nov 28 2016
Detected 3 new flakes for test/step "AutofillManagerTest.ImportFormDataCreditCardHTTPS". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPAsSBUZsYWtlIjFBdXRvZmlsbE1hbmFnZXJUZXN0LkltcG9ydEZvcm1EYXRhQ3JlZGl0Q2FyZEhUVFBTDA. This message was posted automatically by the chromium-try-flakes app.
,
Nov 28 2016
Issue 667980 has been merged into this issue.
,
Nov 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/709468576e349ad110339c25639f52c8151c3834 commit 709468576e349ad110339c25639f52c8151c3834 Author: magjed <magjed@chromium.org> Date: Mon Nov 28 14:06:37 2016 Disable flaky AutofillManagerTest.ImportFormDataCreditCardHTTP(S) tests BUG= 666704 TBR=mathp@chromium.org NOTRY=True Review-Url: https://codereview.chromium.org/2536663002 Cr-Commit-Position: refs/heads/master@{#434648} [modify] https://crrev.com/709468576e349ad110339c25639f52c8151c3834/components/autofill/core/browser/autofill_manager_unittest.cc
,
Nov 28 2016
,
Nov 29 2016
Issue 668919 has been merged into this issue.
,
Nov 29 2016
Issue 668740 has been merged into this issue.
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38f0f99fbccb70bdb28ccb4f4d8ae274513ce3a7 commit 38f0f99fbccb70bdb28ccb4f4d8ae274513ce3a7 Author: battre <battre@chromium.org> Date: Tue Nov 29 13:13:27 2016 Disable flaky AutofillManagerTest.UploadCreditCard [ RUN ] AutofillManagerTest.UploadCreditCard ../../components/autofill/core/browser/autofill_manager_unittest.cc:4496: Failure Value of: autofill_manager_->credit_card_was_uploaded() Actual: false Expected: true BUG= 666704 TBR=mathp@chromium.org Review-Url: https://codereview.chromium.org/2533253002 Cr-Commit-Position: refs/heads/master@{#434970} [modify] https://crrev.com/38f0f99fbccb70bdb28ccb4f4d8ae274513ce3a7/components/autofill/core/browser/autofill_manager_unittest.cc
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30a937312f5992b685cc7c2fed1ec9972681b10c commit 30a937312f5992b685cc7c2fed1ec9972681b10c Author: battre <battre@chromium.org> Date: Tue Nov 29 13:56:00 2016 Disable flaky AutofillManagerTest.CreditCardSavedWhenAutocompleteOff [ RUN ] AutofillManagerTest.CreditCardSavedWhenAutocompleteOff ../../components/autofill/core/browser/autofill_manager_unittest.cc:3695: Failure Actual function call count doesn't match EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _))... Expected: to be called once Actual: never called - unsatisfied and active BUG= 666704 TBR=mathp@chromium.org Review-Url: https://codereview.chromium.org/2540673002 Cr-Commit-Position: refs/heads/master@{#434981} [modify] https://crrev.com/30a937312f5992b685cc7c2fed1ec9972681b10c/components/autofill/core/browser/autofill_manager_unittest.cc
,
Oct 17 2017
,
Dec 1 2017
Issue 789483 has been merged into this issue.
,
Dec 5 2017
Unit Test: failed @ components_unittests Latest M63 Build: 63.0.3239.83 Build bot Link: https://uberchromegw.corp.google.com/i/official.android/builders/test-official-arm/builds/2244 Error Link: https://uberchromegw.corp.google.com/i/official.android/builders/test-official-arm/builds/2244/steps/Unit%20Test%3A%20components_unittests/logs/stdio
,
Dec 5 2017
,
Dec 5 2017
Seb, can you please take a look at this? The bug is old and IMO Issue 789483 shouldn't have been a duplicate...but either way, I think this is related to your CC year fix. Does it need merged into M63 (if it wasn't already)?
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e44e1edb0ebbc5fa17040dfcfb14d3d81993c91 commit 5e44e1edb0ebbc5fa17040dfcfb14d3d81993c91 Author: sebsg <sebsg@chromium.org> Date: Tue Dec 05 21:27:54 2017 [Autofill] Fix hardcoded time related issues in Autofill tests. Bug: 666704 Change-Id: I47e7b2c32c2fdb27d04c14dea0e100c297205c52 Reviewed-on: https://chromium-review.googlesource.com/809724 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#645} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/5e44e1edb0ebbc5fa17040dfcfb14d3d81993c91/components/autofill/core/browser/autofill_manager_unittest.cc [modify] https://crrev.com/5e44e1edb0ebbc5fa17040dfcfb14d3d81993c91/components/autofill/core/browser/credit_card_unittest.cc
,
Dec 5 2017
Yeah the same issue was on M63. I couldn't merge since all the tests were moved in 64.
,
Dec 5 2017
I approved this merge over hangout.
,
Dec 15 2017
Latest M63 Build: 63.0.3239.111 Unit Test: failed @ components_unittests Build bot Link: https://uberchromegw.corp.google.com/i/official.android/builders/test-official-arm/builds/2275 Error Link: https://uberchromegw.corp.google.com/i/official.android/builders/test-official-arm/builds/2244/steps/Unit%20Test%3A%20components_unittests/logs/stdio
,
Dec 15 2017
../../components/autofill/core/browser/autofill_manager_unittest.cc:5027: Failure Expected: 2017 To be equal to: saved_card->expiration_year() Which is: 2018 The NextYear() problem continues to rear its ugly head. :(
,
Dec 15 2017
I cannot repro locally... Will continue to investigate
,
Jan 4 2018
Latest M63 Build: 64.0.3282.73 Unit Test: failed @ components_unittests Build bot Link: https://uberchromegw.corp.google.com/i/official.android/builders/test-official-arm/builds/2335 Error Link: https://uberchromegw.corp.google.com/i/official.android/builders/test-official-arm/builds/2335/steps/Unit%20Test%3A%20components_unittests/logs/stdio
,
Jan 5 2018
https://chromium-review.googlesource.com/c/chromium/src/+/852394 is on the way. Thanks
,
Jan 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5206c9046d570232f9895a6436555653027c969f commit 5206c9046d570232f9895a6436555653027c969f Author: Sebastien SG <sebsg@chromium.org> Date: Mon Jan 08 13:07:55 2018 [Autofill] Fix test failures in credit_card_save_manager_unittest.cc Bug: 666704 Change-Id: I1eb55155e616a979a7afef71c628ac1c16b79ddf Reviewed-on: https://chromium-review.googlesource.com/852394 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#442} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/5206c9046d570232f9895a6436555653027c969f/components/autofill/core/browser/credit_card_save_manager_unittest.cc
,
Jan 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42f43ad751b6232a8414189e5334b409e25a8bfc commit 42f43ad751b6232a8414189e5334b409e25a8bfc Author: sebsg <sebsg@chromium.org> Date: Mon Jan 08 22:07:06 2018 [Autofill] Fix last year related test failure. Bug: 666704 Change-Id: I7abf6822f15609e6d741b711753044639a32f8c0 Reviewed-on: https://chromium-review.googlesource.com/855062 Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/branch-heads/3282@{#449} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/42f43ad751b6232a8414189e5334b409e25a8bfc/components/autofill/core/browser/credit_card_unittest.cc
,
Jan 17 2018
Latest M64 Build: 64.0.3282.99 Unit Test: failed @ components_unittests Build bot Link: https://uberchromegw.corp.google.com/i/official.android/builders/test-official-arm/builds/2373 Error Link: https://uberchromegw.corp.google.com/i/official.android/builders/test-official-arm/builds/2373/steps/Unit%20Test%3A%20components_unittests/logs/stdio
,
Jan 17 2018
It seems the error comes from this file: crash_key_unittest.cc At glance it doesn't seem related to Autofill? |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by msramek@chromium.org
, Nov 18 2016