Issue metadata
Sign in to add a comment
|
PG CQ plugin doesn't warn any more if I accidentally click "submit" |
||||||||||||||||||||||
Issue descriptionWe've just had broken code committed to chromium/tools/build repo as a result.
,
Nov 18 2016
You could put in a warning in commitqueue.js, but deploying that will take time. Editing project.config will take a few seconds.
,
Nov 18 2016
I am certain there was a warning before. It stopped working just recently.
,
Nov 18 2016
,
Nov 18 2016
The warning I think actually comes from chumpdetector.js, not commitqueue.js. I recently landed some changes to the chumpdetector config: https://chromium.googlesource.com/All-Projects/+log/refs/meta/config/chumpdetector.config https://chrome-internal.googlesource.com/All-Projects/+log/refs/meta/config/chumpdetector.config Maybe those changes are broken?
,
Nov 20 2016
Hey, yes, indeed, it's chumpdetector plugin. But the changes you've referenced are 10 days old, i thought it was working after those landed, but am not sure.
,
Nov 20 2016
And I've just seen it working on my Gerrit plugin project[1]. So, that explains why I've seen it so recently, so perhaps those changes of yours are responsible, but I don't yet see how.
,
Nov 22 2016
,
Nov 23 2016
,
Dec 21 2016
I'm doing a lot of work on the chumpdetector plugin (see https://bugs.chromium.org/p/chromium/issues/detail?id=671878 and https://bugs.chromium.org/p/chromium/issues/detail?id=673779), and this should be resolved at the same time.
,
Jan 5 2017
Update: Lots of changes to chumpdetector have been landed, making it way easier to verify that configs are correct, and manage configs on a per-project basis. But changes haven't been deployed yet; probably have to wait another week for next deployment.
,
Jan 10 2017
As can be seen on https://canary-chromium-review.googlesource.com/c/426370/, chromium/tools/build (and all other repos which inherit from infra) now correctly have the chumpdetector enabled on canary. This will be rolled out to prod later this week. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rmis...@google.com
, Nov 18 2016