New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666694 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

PG CQ plugin doesn't warn any more if I accidentally click "submit"

Project Member Reported by tandrii@chromium.org, Nov 18 2016

Issue description

We've just had broken code committed to chromium/tools/build repo as a result.
 

Comment 1 by rmis...@google.com, Nov 18 2016

Easy solution is to restrict who sees the submit button in project.config.
You could restrict it just to git-admins:
	submit = group mdb/chrome-git-admins

I had the submit button for skia restricted to git-admins but made it available to all committers temporarily as a workaround for https://bugs.chromium.org/p/chromium/issues/detail?id=634944

Comment 2 by rmis...@google.com, Nov 18 2016

You could put in a warning in commitqueue.js, but deploying that will take time. Editing project.config will take a few seconds.
I am certain there was a warning before. It stopped working just recently.
Labels: Type-Bug-Regression

Comment 5 by aga...@chromium.org, Nov 18 2016

The warning I think actually comes from chumpdetector.js, not commitqueue.js. I recently landed some changes to the chumpdetector config:

https://chromium.googlesource.com/All-Projects/+log/refs/meta/config/chumpdetector.config
https://chrome-internal.googlesource.com/All-Projects/+log/refs/meta/config/chumpdetector.config

Maybe those changes are broken?
Hey, yes, indeed, it's chumpdetector plugin. But the changes you've referenced are 10 days old, i thought it was working after those landed, but am not sure.
And I've just seen it working on my Gerrit plugin project[1]. So, that explains why I've seen it so recently, so perhaps those changes of yours are responsible, but I don't yet see how.
Components: Infra>Git

Comment 9 by benhenry@google.com, Nov 23 2016

Labels: Pri-2
Owner: aga...@chromium.org
Status: Started (was: Untriaged)
I'm doing a lot of work on the chumpdetector plugin (see https://bugs.chromium.org/p/chromium/issues/detail?id=671878 and https://bugs.chromium.org/p/chromium/issues/detail?id=673779), and this should be resolved at the same time.
Update: Lots of changes to chumpdetector have been landed, making it way easier to verify that configs are correct, and manage configs on a per-project basis. But changes haven't been deployed yet; probably have to wait another week for next deployment.
Status: Fixed (was: Started)
As can be seen on https://canary-chromium-review.googlesource.com/c/426370/, chromium/tools/build (and all other repos which inherit from infra) now correctly have the chumpdetector enabled on canary. This will be rolled out to prod later this week.

Sign in to add a comment