Issue metadata
Sign in to add a comment
|
The build for AArch64 Linux build is broken due to ignored enable_nacl
Reported by
ossy.sze...@gmail.com,
Nov 18 2016
|
||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 5.1; rv:49.0) Gecko/20100101 Firefox/49.0 Steps to reproduce the problem: args.gn: --------- enable_nacl=false treat_warnings_as_errors=false proprietary_codecs=true ffmpeg_branding="Chrome" linux_use_bundled_binutils=false clang_use_chrome_plugins=false cc_wrapper="icecc" is_debug=false target_cpu="arm64" build log: ----------- In file included from ../native_client/src/shared/platform/nacl_secure_random_common.c:11: In file included from ../native_client/src/shared/platform/nacl_log.h:61: ../native_client/src/include/portability.h:90:2: error: Unrecognized host architecture #error Unrecognized host architecture ^ 1 error generated. In file included from ../native_client/src/shared/platform/nacl_interruptible_mutex.c:12: ../native_client/src/include/portability.h:90:2: error: Unrecognized host architecture #error Unrecognized host architecture ^ ... I set enable_nacl=false, but it seems the build system ignores it and tries to build nacl, which isn't supported on AArch64. What is the expected behavior? What went wrong? The build is broken. Did this work before? N/A Chrome version: Channel: n/a OS Version: Flash Version:
,
Nov 18 2016
,
Nov 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d584dd76b4215a83da850bbfcdd0fdb2527e9c57 commit d584dd76b4215a83da850bbfcdd0fdb2527e9c57 Author: ossy.szeged <ossy.szeged@gmail.com> Date: Mon Nov 21 11:36:18 2016 Build native client files only if enable_nacl is true. Native client is unsupported on AArch64 Linux and building its files unconditionally caused build failure. BUG= 666690 Review-Url: https://codereview.chromium.org/2511363002 Cr-Commit-Position: refs/heads/master@{#433511} [modify] https://crrev.com/d584dd76b4215a83da850bbfcdd0fdb2527e9c57/AUTHORS [modify] https://crrev.com/d584dd76b4215a83da850bbfcdd0fdb2527e9c57/BUILD.gn
,
Nov 22 2016
Adding the current Dev milestone. Please close the issue once the build succeeds.
,
Dec 8 2016
ossy.szeged@, Could you please respond as per comment #4
,
Dec 8 2016
This issue is fixed by that CL, we can close this issue, but I don't have the power to do it. But the is still broken because of an other issue: https://bugs.chromium.org/p/chromium/issues/detail?id=668205
,
Dec 8 2016
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ossy.sze...@gmail.com
, Nov 18 2016